Conversation
zvonand
added
releasy
20 of 33 tasks
Cherry-pick of ClickHouse#107960 Add an optional cache for vended credentials of REST data lake catalogs, controlled by the new `DataLakeCatalog` database setting `vended_credentials_cache_ttl` (seconds, default `300`, `0` disables caching). Azure read/write buffers, listing, delete paths and metadata probes refresh credentials through the catalog callback once on an authentication error. Adapted to antalya-26.8: * `ICatalog::getCredentialsConfigurationCallback` has no `table_metadata` parameter here: `RestCatalog` checks the table identity against `storage_id.uuid`, and `UnityCatalog` picks Azure or S3 credentials by the content of the credentials response. * `UnityV2Catalog` does not exist here, so its hunk is skipped. * `ReadBufferFromAzureBlobStorage` keeps the existing `blob_client` member instead of the upstream lazy `getBlobClient` accessor; `checkReturnedRange` does not exist here. * `AzureObjectStorage` keeps plain `connection_params` and `auth_method`; there is no `cloneImpl` or `successful_objects` out-parameter here.
zvonand
force-pushed
the
feature/antalya-26.8/ClickHouse-ClickHouse-pr-107960
branch
from
September 28, 2026 09:42
f04e570 to
6c6ec46
Compare
`getDecimalScale` was only reachable through `Functions/identity.h` -> `DataTypes/Native.h`, which is included under `USE_EMBEDDED_COMPILER`. The embedded compiler is disabled in MSan builds, so the build failed with "use of undeclared identifier 'getDecimalScale'". CI report: https://altinity-build-artifacts.s3.amazonaws.com/PRs/2382/6c6ec46d270461947cbba184d9d96e154004f97f/build_amd_msan/build_clickhouse/build_clickhouse.log PR: #2382
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add option to cache vended credentials for REST catalogs; add a setting
vended_credentials_cache_ttl(seconds). 300 by default. 0 means no caching.Workflow [PR]
Sync PR [sync-upstream/pr/107960] (ClickHouse#107960 by @zvonand).
Cherry-picked from ClickHouse#107960.
Now, new vended credentials are requested on each metadata request. This PR adds an (optional) cache for creds with configurable TTL.