Conversation
Strict readers are a leftover of the codec rewrites. Every object is JSON with the `!` rule for decision-changing fields, so strictness has no job left, and it made any optional field on `cas_run`, fold seal, `cas_ref_ckpt`, `cas_ref_catalog` or `cas_gc_maintenance_state` a compatibility-version bump. Remove the enum, the traits column and the reader parameter; the seven sites that rejected unknown keys with their own throw go through `skipUnknown`. Per object, a test that an unknown ordinary key is skipped and one that an unknown `!` key fails. Reader-only change. Signed-off-by: Mikhail Filimonov <mfilimonov@altinity.com>
k-morozov
approved these changes
Oct 1, 2026
k-morozov
left a comment
There was a problem hiding this comment.
After this PR, we should discuss whether we need ! at all, or whether a format version bump would be a better choice.
11 of 30 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
KeyStrictnessswitch: every CAS on-store reader skips an unknown ordinary key, and an unknown!-prefixed key fails withUNKNOWN_FORMAT_VERSION.Strict readers are a leftover of the codec rewrites. Since every object is JSON with the
!rule for decision-changing fields, strictness has no job left, and it made any optional field oncas_run, fold seal,cas_ref_ckpt,cas_ref_catalogorcas_gc_maintenance_statea compatibility-version bump. The switch was also declared twice (traits table and each reader call) and the two disagreed forcas_gc_maintenance_state.Changes
JsonObjectReaderparameter removed; seven sites that rejected unknown keys with their ownthrowgo throughskipUnknown.!key fails.storage-layout.mdandFormats/README.mdstate the rule once.Risks / notes
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
CAS on-store readers skip unknown optional fields in every object type, so later releases can add fields to
cas_run, fold seal,cas_ref_ckpt,cas_ref_catalogandcas_gc_maintenance_stateobjects without a format version bump.Documentation entry for user-facing changes
CI/CD Options
Exclude tests:
Regression jobs to run:
🤖 Generated with Claude Code