fix(s3): fallback retry with Content-MD5 for DeleteObjects#1330
Open
BorisTyshkevich wants to merge 1 commit intoAltinity:masterfrom
Open
fix(s3): fallback retry with Content-MD5 for DeleteObjects#1330BorisTyshkevich wants to merge 1 commit intoAltinity:masterfrom
BorisTyshkevich wants to merge 1 commit intoAltinity:masterfrom
Conversation
Collaborator
|
did you see d18eef7 ? |
Contributor
Author
|
yes, and already recommended to the client |
Collaborator
|
ok. will merge master and will merge later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteObjectsin 2.6.42 for S3-compatible providers requiringContent-MD5(e.g. Huawei S3)request_content_md5: truebehavior unchangedDetails
When
DeleteObjectsfails withInvalidRequest+ missingContent-MD5, retry the same batch once with MD5 middleware enabled.Validation
go test ./pkg/storage -run TestIsDeleteObjectsMissingContentMD5Error -vgo test ./pkg/storageCloses #1329