Repository navigation
Implement Hetzner for tests and artifact storage - #151
Merged
Merged
Conversation
| echo "aws_endpoint_args=$aws_endpoint_args" >>$GITHUB_ENV | ||
|
|
||
| JOB_REPORT_INDEX=$JOB_BUCKET_URL/index.html#$artifact_s3_dir/ | ||
| echo "JOB_REPORT_INDEX=$JOB_REPORT_INDEX" >>$GITHUB_ENV |
Collaborator
There was a problem hiding this comment.
Why was this line removed? $JOB_REPORT_INDEX is still read in .github/create_and_upload_logs.sh:9 (tfs report results -a "$JOB_REPORT_INDEX"), and that runs in a separate job step — without the $GITHUB_ENV export it arrives empty and the report loses its "Artifacts" section. The uploads themselves are fine, SUITE_REPORT_BUCKET_PATH and SUITE_REPORT_INDEX_URL are still exported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Hetzner as an artifact storage option and use it by default (to migrate away from aws).
Add Hetzner support for s3 suites - s3, tiered_storage, benchmark, and parquet
aws_alloption to run all suites with awsMinor clean up such as removing trailing whitespaces and removing unused gitlab files