fix(trip-service): resolve race condition in distributed trip assignment lock#21
Merged
Conversation
…ent lock Fixed critical race condition causing HTTP 500 errors under high concurrency (200 concurrent drivers). The issue occurred when JPA's optimistic locking exception was thrown at transaction commit time, outside the try-catch block. Root Cause: - tripRepository.save() defers DB write until transaction commit - Transaction commits AFTER method returns (outside try-catch) - StaleObjectStateException thrown at commit time escapes exception handler - Results in HTTP 500 instead of graceful 409 Conflict Solution: - Changed save() to saveAndFlush() to force immediate DB write - Exception now caught within try-catch block - Returns AcceptResult.ALREADY_ASSIGNED (409 Conflict) gracefully - Added @slf4j and warning log for optimistic lock conflicts - Simplified DriverController to forward responses without redundant error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed critical race condition causing HTTP 500 errors under high concurrency (200 concurrent drivers). The issue occurred when JPA's optimistic locking exception was thrown at transaction commit time, outside the try-catch block.
Root Cause:
Solution: