Skip to content

Register improve#295

Open
Vidhi-Ajmera16355 wants to merge 6 commits into
Amarjha01:masterfrom
Vidhi-Ajmera16355:register-improve
Open

Register improve#295
Vidhi-Ajmera16355 wants to merge 6 commits into
Amarjha01:masterfrom
Vidhi-Ajmera16355:register-improve

Conversation

@Vidhi-Ajmera16355

Copy link
Copy Markdown

📄 Description

This PR improves the Registration Page by enhancing form validation, improving UI consistency, and ensuring smoother user experience.
Key updates include:

  • Added proper client-side validation for email, password, and confirm password fields.
  • Improved error messages for better clarity.
  • Enhanced responsiveness of the registration form for mobile devices.
  • Updated styling to align with project design guidelines.

These changes are necessary to make the registration process more user-friendly, prevent invalid submissions, and maintain design consistency across the app.

✅ Checklist

  • My code follows the project’s coding guidelines.
  • I have tested these changes locally.
  • I have added necessary documentation/comments (if applicable).
  • I have linked the related issue.

🔗 Related Issue

Closes #275

📸 Screenshots

image

🙏 Additional Notes

  • Future scope: Integration of backend API validation for stronger security.
  • Open for feedback on UI/UX improvements.

@CHHemant

Copy link
Copy Markdown
Collaborator

@Vidhi-Ajmera16355 This branch has conflicts that must be resolved

@CHHemant

CHHemant commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

client/src/pages/Registration.jsx This branch has conflicts that must be resolved
@Vidhi-Ajmera16355

// Password Strength Indicator Component
const PasswordStrengthIndicator = ({ password }) => {
const requirements = [
{ test: (pwd) => pwd.length >= 8, label: "At least 8 characters" },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be configurable. Create a config and provide the content from there

return "Strong";
};

const getStrengthBarColor = () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead if use switch here

const handleLogout = () => {
localStorage.removeItem('token');
localStorage.removeItem('userData');
localStorage.removeItem("token");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automate these rules by using eslint

@CHHemant

CHHemant commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

@Vidhi-Ajmera16355 This branch has conflicts that must be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Registration Page Improvements

3 participants