Implement device-wise notification mute/unmute#822
Open
CircuitCoder wants to merge 1 commit into
Open
Conversation
CircuitCoder
force-pushed
the
feat-mute
branch
from
November 8, 2025 07:35
4501db0 to
925e86d
Compare
This was referenced Nov 29, 2025
Closed
Starosdev
added a commit
to Starosdev/scrutiny
that referenced
this pull request
Nov 30, 2025
Starosdev
pushed a commit
to Starosdev/scrutiny
that referenced
this pull request
Nov 30, 2025
## [1.1.0](v1.0.0...v1.1.0) (2025-11-30) ### Features * Add "day" as resolution for temperature graph ([2670af2](2670af2)) * add day resolution for temperature graph (upstream PR [AnalogJ#823](https://github.com/Starosdev/scrutiny/issues/823)) ([2d6ffa7](2d6ffa7)) * add setting to enable/disable SCT temperature history (upstream PR [#557](#557)) ([c3692ac](c3692ac)) * Implement device-wise notification mute/unmute ([925e86d](925e86d)) * implement device-wise notification mute/unmute (upstream PR [AnalogJ#822](https://github.com/Starosdev/scrutiny/issues/822)) ([ea7102e](ea7102e)) * implement Prometheus metrics support (upstream PR [AnalogJ#830](https://github.com/Starosdev/scrutiny/issues/830)) ([7384f7d](7384f7d)) * support SAS temperature (upstream PR [AnalogJ#816](https://github.com/Starosdev/scrutiny/issues/816)) ([f954cc8](f954cc8)) ### Bug Fixes * better handling of ata_sct_temperature_history (upstream PR [AnalogJ#825](https://github.com/Starosdev/scrutiny/issues/825)) ([d134ad7](d134ad7)) * **database:** add missing temperature parameter in SCSI migration ([df7da88](df7da88)) * support transient SMART failures (upstream PR [#375](#375)) ([601775e](601775e)) * **ui:** fix temperature conversion in temperature.pipe.ts (upstream PR [AnalogJ#815](https://github.com/Starosdev/scrutiny/issues/815)) ([e0f2781](e0f2781)) ### Refactoring * use limit() instead of tail() for fetching smart attributes (upstream PR [AnalogJ#829](https://github.com/Starosdev/scrutiny/issues/829)) ([2849531](2849531))
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Muting notification for a certain device may be helpful in certain cases, such as when a degraded drive is waiting for replacement. This PR adds the backend and frontend changes for muting a device.
It's a pleasant surprise that a setting dialog containing a "notification" entry in the device detail page is already present. This PR reuse that dialog.
Changes
mute: booleanto thedevicetable.mute = true, skip notification./device/:wwn/muteand/device/:wwn/unmutefor setting the mute status in devices.Future works
Implementation presented in this PR has some shortcomings:
The dialog closes. -> Send update request -> Refresh drive data
One may see some opportunity for races here. However races does not introduce any inconsistency state, so no additional locking is done in this PR.
line-heightas its means of vertical aligning, but that means we'll bundle a icon font.Screenshots