Test settlement status consistency - #253
Merged
Jagadeeshftw merged 3 commits intoJul 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've completed the requested task!
Here's what was done:
src/test.rs. It creates multiple settlements spanning every distinct lifecycle status defined in src/types.rs
(Pending, Executed, Cancelled, Expired).
list_settlements_by_status(status, 0, u32::MAX) exactly yields a list length equal to
settlement_count_by_status(status). It performs this check initially, and then mutates a previously-pending
settlement to an executed state before running the full verification pass again.
src/lib.rs. Both methods properly iterate over the global settlement counter in a perfectly identical way without
any discrepancies in their filter logic. Since they inherently mirror the same bounds and equality logic, there
was no drift or discrepancy to fix!
consistency.
closes #100