Skip to content

fix: remove duplicate back links on detail pages now covered by Breadcrumb (#238) #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ayinkx wants to merge 1 commit into from
Closed

fix: remove duplicate back links on detail pages now covered by Breadcrumb (#238) #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ click handlers rather than from WalletProvider, so a cross-tab
storage sync updates the button without notifying a user who didn't
take the action. The button label and the disconnect confirmation
dialog are unchanged.
Changed
UX: removed the standalone "← Back to anchors" / "← Back to settlements"
links from the anchor and settlement detail pages; the Breadcrumb
rendered above each detail component is now the single back-navigation
affordance on those pages.
Fixed
Build: restored declarations lost in an earlier merge that broke
next build — AnchorsPanel's URL-backed sort state (sortParam,
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions src/components/AnchorDetail.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,6 @@ describe("AnchorDetail", () => {

// Expect the distinct not‑found text
expect(await screen.findByText(/anchor not found/i)).toBeInTheDocument();
const backLink = screen.getByRole("link", { name: /← back to anchors/i });
expect(backLink).toBeInTheDocument();
expect(backLink).toHaveAttribute("href", "/anchors");
});

it("hides the deactivate action for an already-inactive anchor", async () => {
Expand Down
6 changes: 0 additions & 6 deletions src/components/AnchorDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,6 @@ export function AnchorDetail({

return (
<div className="space-y-6">
<Link
href="/anchors"
className="text-sm text-zinc-400 hover:text-zinc-100"
>
← Back to anchors
</Link>
<Card>
{state.status === "loading" ? (
<Spinner label="Loading anchor…" />
Expand Down
3 changes: 0 additions & 3 deletions src/components/SettlementDetail.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ describe("SettlementDetail", () => {

// Expect the distinct not‑found text
expect(await screen.findByText(/settlement not found/i)).toBeInTheDocument();
const backLink = screen.getByRole('link', { name: /← back to settlements/i });
expect(backLink).toBeInTheDocument();
expect(backLink).toHaveAttribute('href', '/settlements');
});


Expand Down
6 changes: 0 additions & 6 deletions src/components/SettlementDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,6 @@ export function SettlementDetail({

return (
<div className="space-y-6">
<Link
href="/settlements"
className="text-sm text-zinc-400 hover:text-zinc-100"
>
← Back to settlements
</Link>
<Card>
{state.status === "loading" ? (
<Spinner label="Loading settlement…" />
Expand Down
Loading