Skip to content

SettlementTable.test.tsx passes Element where HTMLElement is required at 5 sites — queries are returning a weaker type than the assertions need #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jagadeeshftw merged 1 commit into from
Aug 29, 2026
Merged

SettlementTable.test.tsx passes Element where HTMLElement is required at 5 sites — queries are returning a weaker type than the assertions need #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions src/components/SettlementTable.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,8 @@ describe("SettlementTable sorting", () => {
it("shows the amount and fee totals for the visible rows", () => {
render(<SettlementTable settlements={settlements} />);

const totalRow = document.querySelector("tfoot tr");
expect(totalRow).not.toBeNull();
expect(within(totalRow!).getAllByRole("cell").map((cell) => cell.textContent)).toEqual([
const totalRow = screen.getByRole("row", { name: /Total \(visible rows\)/ });
expect(within(totalRow).getAllByRole("cell").map((cell) => cell.textContent)).toEqual([
"Total (visible rows)",
"600",
"6",
Expand Down Expand Up @@ -261,15 +260,14 @@ describe("SettlementTable mobile layout", () => {
render(<SettlementTable settlements={settlements} />);
const cards = screen.getAllByTestId("settlement-card");
expect(cards).toHaveLength(settlements.length);
settlements.forEach((s) => {
const card = screen
.getByText(`Settlement #${s.id}`)
.closest('[data-testid="settlement-card"]');
settlements.forEach((s, index) => {
const card = cards[index];
expect(card).toBeInTheDocument();
expect(within(card!).getByText(s.anchor)).toBeInTheDocument();
expect(within(card!).getByText(s.asset)).toBeInTheDocument();
expect(within(card!).getByText(formatAmount(s.amount))).toBeInTheDocument();
expect(within(card!).getByText(formatAmount(s.fee))).toBeInTheDocument();
expect(within(card).getByRole("link", { name: `Settlement #${s.id}` })).toBeInTheDocument();
expect(within(card).getByText(s.anchor)).toBeInTheDocument();
expect(within(card).getByText(s.asset)).toBeInTheDocument();
expect(within(card).getByText(formatAmount(s.amount))).toBeInTheDocument();
expect(within(card).getByText(formatAmount(s.fee))).toBeInTheDocument();
});
});
});