Skip to content

Modernize Pi components using Entity Descriptions #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Louis983257 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Modernize Pi components using Entity Descriptions #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6efc446
Fix: Replace deprecated async_forward_entry_setup
Louis983257 Jun 12, 2025
13c11dc
Update button.py
Louis983257 Jan 30, 2026
7df8e2d
Update device.py
Louis983257 Jan 30, 2026
3679636
Update binary_sensor.py
Louis983257 Jan 30, 2026
92497cf
Update switch.py
Louis983257 Jan 30, 2026
368eecc
Update __init__.py
Louis983257 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions custom_components/speedport/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,9 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:

entry.async_on_unload(entry.add_update_listener(update_listener))

for platform in PLATFORMS:
hass.async_create_task(
hass.config_entries.async_forward_entry_setup(entry, platform)
)
# Fix: Modernisierte Plattform-Einbindung
await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS)

return True


Expand Down
3 changes: 3 additions & 0 deletions custom_components/speedport/binary_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,10 @@ def is_on(self) -> bool | None:
== self.entity_description.value
)

@property
def available(self) -> bool:
"""Return True if entity is available."""
if self._speedport.get(self.entity_description.key) is None:
return False
# Fix: Aufruf der super().available Eigenschaft
return super().available
8 changes: 4 additions & 4 deletions custom_components/speedport/button.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.typing import HomeAssistantType
# Die Zeile mit HomeAssistantType wurde entfernt
from speedport import Speedport

from .const import DOMAIN
Expand All @@ -29,7 +29,7 @@ async def async_setup_entry(
class SpeedportReconnectButton(ButtonEntity, SpeedportEntity):
_attr_device_class = ButtonDeviceClass.RESTART

def __init__(self, hass: HomeAssistantType, speedport: Speedport) -> None:
def __init__(self, hass: HomeAssistant, speedport: Speedport) -> None:
"""Initialize the button entity."""
super().__init__(hass, speedport)
self._attr_name = "Reconnect"
Expand All @@ -44,7 +44,7 @@ async def async_press(self) -> None:
class SpeedportRebootButton(ButtonEntity, SpeedportEntity):
_attr_device_class = ButtonDeviceClass.RESTART

def __init__(self, hass: HomeAssistantType, speedport: Speedport) -> None:
def __init__(self, hass: HomeAssistant, speedport: Speedport) -> None:
"""Initialize the button entity."""
super().__init__(hass, speedport)
self._attr_name = "Reboot"
Expand All @@ -59,7 +59,7 @@ async def async_press(self) -> None:
class SpeedportWPSButton(ButtonEntity, SpeedportEntity):
_attr_device_class = ButtonDeviceClass.IDENTIFY

def __init__(self, hass: HomeAssistantType, speedport: Speedport) -> None:
def __init__(self, hass: HomeAssistant, speedport: Speedport) -> None:
"""Initialize the button entity."""
super().__init__(hass, speedport)
self._attr_name = "WPS on"
Expand Down
10 changes: 5 additions & 5 deletions custom_components/speedport/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
import logging
from datetime import timedelta

from homeassistant.core import callback
from homeassistant.core import callback, HomeAssistant
from homeassistant.helpers.device_registry import DeviceInfo
from homeassistant.helpers.typing import HomeAssistantType
# HomeAssistantType wurde hier entfernt
from homeassistant.helpers.update_coordinator import (
DataUpdateCoordinator,
CoordinatorEntity,
Expand All @@ -17,7 +17,7 @@


class SpeedportCoordinator(DataUpdateCoordinator[None]):
def __init__(self, hass: HomeAssistantType, device: Speedport):
def __init__(self, hass: HomeAssistant, device: Speedport):
"""Initialize my coordinator."""

super().__init__(
Expand All @@ -38,7 +38,7 @@ class SpeedportEntity(CoordinatorEntity[SpeedportCoordinator]):
_attr_has_entity_name = True

def __init__(
self, hass: HomeAssistantType, speedport: Speedport, description=None
self, hass: HomeAssistant, speedport: Speedport, description=None
) -> None:
coordinator = get_coordinator(hass, speedport)
super().__init__(coordinator)
Expand Down Expand Up @@ -66,7 +66,7 @@ def _handle_coordinator_update(self) -> None:


def get_coordinator(
hass: HomeAssistantType, speedport: Speedport
hass: HomeAssistant, speedport: Speedport
) -> SpeedportCoordinator:
coordinators = hass.data[DOMAIN]["coordinators"]
if speedport.serial_number in coordinators:
Expand Down
10 changes: 5 additions & 5 deletions custom_components/speedport/switch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.typing import HomeAssistantType
# HomeAssistantType entfernt
from speedport import Speedport

from .const import DOMAIN
Expand All @@ -34,7 +34,7 @@ async def async_setup_entry(
class SpeedportWifiSwitch(SwitchEntity, SpeedportEntity):
_attr_is_on: bool | None = False

def __init__(self, hass: HomeAssistantType, speedport: Speedport) -> None:
def __init__(self, hass: HomeAssistant, speedport: Speedport) -> None:
super().__init__(hass, speedport)
self._speedport: Speedport = speedport
self._attr_icon = "mdi:wifi"
Expand All @@ -57,7 +57,7 @@ async def async_turn_off(self, **kwargs: Any) -> None:
class SpeedportGuestWifiSwitch(SwitchEntity, SpeedportEntity):
_attr_is_on: bool | None = False

def __init__(self, hass: HomeAssistantType, speedport: Speedport) -> None:
def __init__(self, hass: HomeAssistant, speedport: Speedport) -> None:
super().__init__(hass, speedport)
self._speedport: Speedport = speedport
self._attr_icon = "mdi:wifi"
Expand All @@ -80,7 +80,7 @@ async def async_turn_off(self, **kwargs: Any) -> None:
class SpeedportOfficeWifiSwitch(SwitchEntity, SpeedportEntity):
_attr_is_on: bool | None = False

def __init__(self, hass: HomeAssistantType, speedport: Speedport) -> None:
def __init__(self, hass: HomeAssistant, speedport: Speedport) -> None:
super().__init__(hass, speedport)
self._speedport: Speedport = speedport
self._attr_icon = "mdi:wifi"
Expand All @@ -89,7 +89,7 @@ def __init__(self, hass: HomeAssistantType, speedport: Speedport) -> None:

@property
def is_on(self) -> bool | None:
return self._speedport.wlan_office_ssid
return self._speedport.wlan_office_active # Kleiner Fix: hier sollte vermutlich der Status stehen, nicht die SSID

async def async_turn_on(self, **kwargs: Any) -> None:
"""Turn on switch."""
Expand Down