Skip to content

Fix a possible issue with massive-file (from coverity) #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreRenaud merged 4 commits into from
Mar 1, 2026
Merged

Fix a possible issue with massive-file (from coverity) #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bafd207
Missing Symbol & Zapfdingbats font
AndreRenaud Mar 1, 2026
43cee3c
typo
AndreRenaud Mar 1, 2026
39c2953
Reinstate whitespace
AndreRenaud Mar 1, 2026
1a49855
Undo formatting
AndreRenaud Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions pdfgen.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,21 @@ static const char png_chunk_end[] = "IEND";

// PDF standard fonts
static const char *valid_fonts[] = {
"Times-Roman", "Times-Bold",
"Times-Italic", "Times-BoldItalic",
"Helvetica", "Helvetica-Bold",
"Helvetica-Oblique", "Helvetica-BoldOblique",
"Courier", "Courier-Bold",
"Courier-Oblique", "Courier-BoldOblique"};
"Times-Roman",
"Times-Bold",
"Times-Italic",
"Times-BoldItalic",
"Helvetica",
"Helvetica-Bold",
"Helvetica-Oblique",
"Helvetica-BoldOblique",
"Courier",
"Courier-Bold",
"Courier-Oblique",
"Courier-BoldOblique",
"Symbol",
"ZapfDingbats",
};

typedef struct pdf_object pdf_object;

Expand Down
5 changes: 5 additions & 0 deletions tests/massive-file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include "pdfgen.h"
#include <limits.h>
#include <stdlib.h>

int main(int argc, char **argv)
Expand All @@ -9,6 +10,10 @@ int main(int argc, char **argv)

if (argc > 1) {
pagecount = atoi(argv[1]);
if (pagecount < 1 || pagecount > INT_MAX) {
fprintf(stderr, "Invalid page count: %d\n", pagecount);
return 1;
}
}
pdf_set_font(pdf, "Times-Roman");
for (int i = 0; i < pagecount; i++) {
Expand Down