Домашнее задание Activity #3#226
Open
slakop wants to merge 1 commit intoAndroid-Developer-Basic:homework/activity_03from
Open
Домашнее задание Activity #3#226slakop wants to merge 1 commit intoAndroid-Developer-Basic:homework/activity_03from
slakop wants to merge 1 commit intoAndroid-Developer-Basic:homework/activity_03from
Conversation
|
|
||
| val imgUri = imageView.tag as? Uri | ||
| if (imgUri != null) putExtra(Intent.EXTRA_STREAM, imgUri) | ||
| var firstName = findViewById<TextView>(R.id.textview_name).text |
There was a problem hiding this comment.
Используйте val вместо var для переменных firstName, lastName и age, так как они не изменяются. Это соответствует best practices и делает код более безопасным.
| }) | ||
| } | ||
|
|
||
| private fun ViewDialog() |
There was a problem hiding this comment.
Не соответствуют конвенциям именования. Методы должны начинаться с маленькой буквы и быть глаголами. Предлагаю переименовать их в showPhotoSelectionDialog(), showRationaleDialog() и showSettingsDialog()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.