-
Notifications
You must be signed in to change notification settings - Fork 99
Homework_04 (Kotlin#5) implementation. #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vp-Ma
wants to merge
1
commit into
Android-Developer-Basic:master
Choose a base branch
from
Vp-Ma:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| package ru.otus.cars | ||
|
|
||
| import kotlin.random.Random | ||
|
|
||
| class GazStation( private val carsQueue:List<Car>) { | ||
|
|
||
| fun ReFuelCars( ) | ||
| { | ||
| var fuelAmount = 0 | ||
| var realFuelAmnt = 0 | ||
|
|
||
| for( car in carsQueue ) { | ||
| showTankFuelAmount(car) | ||
| fuelAmount = getFuelAmount() | ||
| if ( car.tank.tankMouthType == TankMouthType.FOR_PETROL_FUEl) { | ||
| petrolRefuel( fuelAmount, car ) | ||
| } else if ((car.tank.tankMouthType == TankMouthType.FOR_GAZ_FUEL)) { | ||
| gazRefuel( fuelAmount, car ) | ||
| } else { | ||
| println("Бак взорвался") | ||
| } | ||
| realFuelAmnt = car.tank.getFuelCurrAmount() | ||
| println("В баке ${realFuelAmnt} литров топлива") | ||
| } | ||
| } | ||
| private fun getFuelAmount():Int{ | ||
| println("Сколько требуется топлива?") | ||
| Thread.sleep(300) | ||
| return Random.nextInt(1, 100) | ||
| } | ||
| private fun petrolRefuel( fuelAmount:Int, car:Car ){ | ||
| println("Будет Заправлен бензин. Количество $fuelAmount") | ||
| car.tank.fuelFillUp(fuelAmount) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. По заданию машина заправляется через горловину бака, а не напрямую через бак. Можно добавить в интерфейс Car свойство tankMouth: TankMouth и заправлять через него (например, car.tankMouth.fuelPetrol() для бензина) |
||
| } | ||
|
|
||
| private fun gazRefuel( fuelAmount:Int, car:Car ){ | ||
| println("Будет Заправлен газ. Количествто $fuelAmount") | ||
| car.tank.fuelFillUp(fuelAmount) | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| package ru.otus.cars | ||
|
|
||
| interface Tank { | ||
| fun getFuelCurrAmount(): Int | ||
| fun fuelFillUp(liters: Int) | ||
| fun getTankTankMouthType():Int | ||
| fun getTankCapacity():Int | ||
| } | ||
|
|
||
| enum class TankMouthType{ | ||
| FOR_UNNOWN_FUEL, | ||
| FOR_PETROL_FUEl, | ||
| FOR_GAZ_FUEL | ||
| } | ||
|
|
||
|
|
||
| class FuelTank (val tankVolume: Int, val tankMouthType:TankMouthType ): Tank { | ||
|
|
||
| private var realFuelAmnt = 0 | ||
| private var mouthType = tankMouthType | ||
|
|
||
| override fun getFuelCurrAmount(): Int{ | ||
| return realFuelAmnt | ||
| } | ||
|
|
||
| override fun fuelFillUp(liters: Int) { | ||
|
|
||
| val possibleVol = tankVolume - realFuelAmnt | ||
| if( possibleVol > liters ) { | ||
| realFuelAmnt += liters | ||
| println( "Запралено топлива ${liters} литров" ) | ||
| } | ||
| else if( possibleVol <= liters ){ | ||
| realFuelAmnt += possibleVol | ||
| println( "Запрашиваемый объем слишком большой. Запралено топлива ${possibleVol} литров" ) | ||
| } | ||
| else if( possibleVol == 0){ | ||
| realFuelAmnt = tankVolume | ||
| println("Бак полон. Заправка не требуется") | ||
| } | ||
| } | ||
| override fun getTankTankMouthType():Int { | ||
| return mouthType.ordinal | ||
| } | ||
| override fun getTankCapacity():Int{ | ||
| return tankVolume | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Прямой доступ к car.tank.tankMouthType нарушает инкапсуляцию, так как это поле не является частью интерфейса Tank. Лучше использовать полиморфизм и проверять тип горловины через car.tankMouth
when (car.tankMouth) { is PetrolMouth -> ... is LpgMouth -> ... }