Skip to content

✨🏢 Add foster families emergencies#757

Open
sbellavoine wants to merge 2 commits intodevfrom
tec-111-foster-family-emergencies
Open

✨🏢 Add foster families emergencies#757
sbellavoine wants to merge 2 commits intodevfrom
tec-111-foster-family-emergencies

Conversation

@sbellavoine
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Member

@simonrelet simonrelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trop forte!

Comment thread libs/prisma/schema.prisma
updatedAt DateTime @updatedAt
activities Activity[]

emergencies FosterFamilyEmergencies @default(UNKNOWN)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce qu'il y a une raison particulière pour utiliser une enum à la place d'un boolean ? 🤔

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas forcément, je me suis basée sur un exemple, il me semble que c'était celui des jardins 🤔

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok je vois. Pour emergencies on ne va pas avoir besoin d'UNKNOWN parce que c'est une décision qu'on prends nous, on ne dépends pas sur une FA pour avoir l'info. Tu peux passer le champs en boolean et utiliser false en valeur par défaut 👌

FosterFamilyEmergencies,
React.ReactNode
> = {
[FosterFamilyEmergencies.NO]: <Icon href="icon-tree-slash-solid" />,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vais te fournir les icons a utiliser ici 👌

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci ! :)

Copy link
Copy Markdown
Member

@simonrelet simonrelet Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On va utiliser siren-on-solid.svg quand une FA accepte les urgences et celle là (siren-on-slash-solid.svg) sinon:

siren-on-slash

[FosterFamilyEmergencies.UNKNOWN]: <Icon href="icon-tree-question-solid" />,
};

export function EmergenciesIcon({
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'ai pas l'impression que ce composant soit utilisé.
Tu l'utilises quelque part ? 🤔

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectivement... Je me suis basée sur le Form.Field pour les types de logements. Je vais le supprimer :)


<Separator />

<Emergencies defaultFosterFamily={defaultFosterFamily} />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je mettrais bien ce champs juste après la disponibilité

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je fais la modif :)

);
}

function Emergencies({
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function Emergencies({
function EmergenciesField({

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci !


<SimpleItem icon={<Icon href="icon-hand-holding-heart-solid" />}>
<Markdown components={HIGHLIGHT_COMPONENTS}>
{[TEXT_BY_EMERGENCY[fosterFamily.emergencies]].join("")}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{[TEXT_BY_EMERGENCY[fosterFamily.emergencies]].join("")}
{TEXT_BY_EMERGENCY[fosterFamily.emergencies]}

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants