Pick which combats to delete, load combats on startup, and refresh only on change - #7
Open
raman78 wants to merge 3 commits into
Open
Pick which combats to delete, load combats on startup, and refresh only on change#7raman78 wants to merge 3 commits into
raman78 wants to merge 3 commits into
Conversation
- Replace "Clear Log File" with a dialog listing every combat with checkboxes (select all / none; all but the newest selected by default); deletion keeps the chosen combats' byte ranges and rewrites the log atomically, aborting if any kept combat can't be read. - Show ~15 combats in the dropdown before it scrolls. - Load the combats list on startup and push the latest combat to the overlay as soon as it is enabled, instead of only after Refresh Now. - Only notify handlers when the log actually changed (tracked by size), so auto refresh no longer rebuilds the view (collapsing expanded trees) for no-op events, and re-create the auto-refresh watcher after a delete. - On Linux, watch the log folder while consolidating so the game's writes to a rotating file still drive the live view. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Opening "Clear Log File" now triggers a manual refresh so the dialog always lists every combat in the log, instead of relying on the user having refreshed first. Drops the now-obsolete "refresh first" hint. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The two ignored tests that need a real combat log had a developer's absolute path baked in, which is useless to anyone else. They now read CLA_TEST_COMBATLOG and skip with a note when it is not set. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Three related combats-list improvements, all on top of the existing analysis handler (no new platform deps).
Pick which combats to delete
Load combats on startup
Refresh only when the log actually changed
Includes a unit test for the atomic rewrite helper.
🤖 Generated with Claude Code