Conversation
daria-sorokina-da
left a comment
There was a problem hiding this comment.
@daria-sorokina-da reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @pchenery)
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 92 at r1 (raw file):
try { log.LogInformation("Function executing");
Function FunctionTestCancellationToken executing
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 97 at r1 (raw file):
await Task.Delay(TimeSpan.FromHours(1), cancellationToken); log.LogInformation("Function executed");
Function FunctionTestCancellationToken executed
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 101 at r1 (raw file):
catch (OperationCanceledException) { log.LogWarning("Function cancelled");
Function FunctionTestCancellationToken cancelled
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 109 at r1 (raw file):
[ServiceBusTrigger( "%MessagingServiceBus:SearchRequestsTopic%", "test-cancellation-token",
please call this "test-no-cancellation-token"
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 116 at r1 (raw file):
try { log.LogInformation("Function executing");
Function FunctionTestNoCancellationToken executing
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 121 at r1 (raw file):
await Task.Delay(TimeSpan.FromHours(1)); log.LogInformation("Function executed");
Function FunctionTestNoCancellationToken executed
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 125 at r1 (raw file):
catch (OperationCanceledException) { log.LogWarning("Function cancelled");
Function FunctionTestNoCancellationToken cancelled
pchenery
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @daria-sorokina-da)
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 92 at r1 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
Function FunctionTestCancellationToken executing
Done.
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 97 at r1 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
Function FunctionTestCancellationToken executed
Done.
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 101 at r1 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
Function FunctionTestCancellationToken cancelled
Done.
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 109 at r1 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
please call this "test-no-cancellation-token"
Done.
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 116 at r1 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
Function FunctionTestNoCancellationToken executing
Done.
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 121 at r1 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
Function FunctionTestNoCancellationToken executed
Done.
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 125 at r1 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
Function FunctionTestNoCancellationToken cancelled
Done.
daria-sorokina-da
left a comment
There was a problem hiding this comment.
@daria-sorokina-da reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pchenery)
a discussion (no related file):
No need to merge, will be used for testing
daria-sorokina-da
left a comment
There was a problem hiding this comment.
@daria-sorokina-da reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pchenery).
daria-sorokina-da
left a comment
There was a problem hiding this comment.
@daria-sorokina-da made 3 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @pchenery).
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 85 at r3 (raw file):
[Function(nameof(FunctionTestCancellationToken))] public async Task FunctionTestCancellationToken(
Add a new function FunctionTestCancellationTokenWithWaitAsync with another subscription test-cancellation-token-with-wait-async
await Task.Delay().WaitAsync(cancellationToken);
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 104 at r3 (raw file):
catch (OperationCanceledException) { logger.LogWarning("Function FunctionTestCancellationToken cancelled");
Please add
throw;
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 127 at r3 (raw file):
catch (OperationCanceledException) { logger.LogWarning("Function FunctionTestNoCancellationToken cancelled");
Please add
throw;
pchenery
left a comment
There was a problem hiding this comment.
@pchenery made 3 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @daria-sorokina-da).
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 85 at r3 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
Add a new function FunctionTestCancellationTokenWithWaitAsync with another subscription test-cancellation-token-with-wait-async
await Task.Delay().WaitAsync(cancellationToken);
Done.
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 104 at r3 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
Please add
throw;
Done.
Atlas.MatchingAlgorithm.Functions/Functions/SearchFunctions.cs line 127 at r3 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
Please add
throw;
Done.
daria-sorokina-da
left a comment
There was a problem hiding this comment.
@daria-sorokina-da reviewed 1 file and all commit messages, and resolved 3 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pchenery).
…ce on shut down
This change is