Skip to content

feature: ATL-49: fix match prediction worker pipeline#1447

Merged
andreireznikau merged 4 commits intomasterfrom
atl-49-fix-match-prediction-worker-pipeline
May 6, 2026
Merged

feature: ATL-49: fix match prediction worker pipeline#1447
andreireznikau merged 4 commits intomasterfrom
atl-49-fix-match-prediction-worker-pipeline

Conversation

@andreireznikau
Copy link
Copy Markdown
Contributor

@andreireznikau andreireznikau commented May 5, 2026

Enhance deployment pipeline with build context and validation steps


This change is Reviewable

@andreireznikau andreireznikau requested a review from a team as a code owner May 5, 2026 12:46
Copy link
Copy Markdown
Contributor

@daria-sorokina-da daria-sorokina-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daria-sorokina-da reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andreireznikau).


master-prediction-algorithm-build-and-deploy.yml line 37 at r1 (raw file):

    variables:
      - name: CONTAINER_APP_NAME
        value: 'dev-atlas-match-prediction-ca'

This will be a Release pipeline, not Build, right? Will we have a separate pipeline file per environment?

Copy link
Copy Markdown
Contributor Author

@andreireznikau andreireznikau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreireznikau made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on daria-sorokina-da).


master-prediction-algorithm-build-and-deploy.yml line 37 at r1 (raw file):

Previously, daria-sorokina-da (Daria Sorokina) wrote…

This will be a Release pipeline, not Build, right? Will we have a separate pipeline file per environment?

I suggest we go with a single staged pipeline per container app (Build -> Dev -> UAT) with manual triggers for now. This keeps things simple while we figure out the container setup without juggling image tags between pipelines.
Once we are confident I'll hook it into the main one - either extend the existing release definition or refactor it as a YAML pipeline.

Copy link
Copy Markdown
Contributor

@daria-sorokina-da daria-sorokina-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daria-sorokina-da made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andreireznikau).


master-prediction-algorithm-build-and-deploy.yml line 37 at r1 (raw file):

Previously, andreireznikau wrote…

I suggest we go with a single staged pipeline per container app (Build -> Dev -> UAT) with manual triggers for now. This keeps things simple while we figure out the container setup without juggling image tags between pipelines.
Once we are confident I'll hook it into the main one - either extend the existing release definition or refactor it as a YAML pipeline.

Why do we have to juggle the image tag between pipelines? It should correspond to the build number

@andreireznikau
Copy link
Copy Markdown
Contributor Author

master-prediction-algorithm-build-and-deploy.yml line 37 at r1 (raw file):

Previously, daria-sorokina-da (Daria Sorokina) wrote…

Why do we have to juggle the image tag between pipelines? It should correspond to the build number

Build and release pipelines ids differ, so we'll have to pass the image tag from build pipeline to release one. That is not the problem itself but complicates a bit the solution which is, in fact, to be replaced soon.

Copy link
Copy Markdown
Contributor

@daria-sorokina-da daria-sorokina-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daria-sorokina-da made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andreireznikau).


master-prediction-algorithm-build-and-deploy.yml line 37 at r1 (raw file):

Previously, andreireznikau wrote…

Build and release pipelines ids differ, so we'll have to pass the image tag from build pipeline to release one. That is not the problem itself but complicates a bit the solution which is, in fact, to be replaced soon.

Let's have a quick chat about it tomorrow, I'll show you how we solved it in our Gotenberg service

Copy link
Copy Markdown
Contributor

@daria-sorokina-da daria-sorokina-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daria-sorokina-da resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on andreireznikau).

@andreireznikau andreireznikau merged commit dc8f173 into master May 6, 2026
4 checks passed
@andreireznikau andreireznikau deleted the atl-49-fix-match-prediction-worker-pipeline branch May 6, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants