feature: ATL-49: fix match prediction worker pipeline#1447
feature: ATL-49: fix match prediction worker pipeline#1447andreireznikau merged 4 commits intomasterfrom
Conversation
daria-sorokina-da
left a comment
There was a problem hiding this comment.
@daria-sorokina-da reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andreireznikau).
master-prediction-algorithm-build-and-deploy.yml line 37 at r1 (raw file):
variables: - name: CONTAINER_APP_NAME value: 'dev-atlas-match-prediction-ca'
This will be a Release pipeline, not Build, right? Will we have a separate pipeline file per environment?
andreireznikau
left a comment
There was a problem hiding this comment.
@andreireznikau made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on daria-sorokina-da).
master-prediction-algorithm-build-and-deploy.yml line 37 at r1 (raw file):
Previously, daria-sorokina-da (Daria Sorokina) wrote…
This will be a Release pipeline, not Build, right? Will we have a separate pipeline file per environment?
I suggest we go with a single staged pipeline per container app (Build -> Dev -> UAT) with manual triggers for now. This keeps things simple while we figure out the container setup without juggling image tags between pipelines.
Once we are confident I'll hook it into the main one - either extend the existing release definition or refactor it as a YAML pipeline.
daria-sorokina-da
left a comment
There was a problem hiding this comment.
@daria-sorokina-da made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andreireznikau).
master-prediction-algorithm-build-and-deploy.yml line 37 at r1 (raw file):
Previously, andreireznikau wrote…
I suggest we go with a single staged pipeline per container app (Build -> Dev -> UAT) with manual triggers for now. This keeps things simple while we figure out the container setup without juggling image tags between pipelines.
Once we are confident I'll hook it into the main one - either extend the existing release definition or refactor it as a YAML pipeline.
Why do we have to juggle the image tag between pipelines? It should correspond to the build number
|
Previously, daria-sorokina-da (Daria Sorokina) wrote…
Build and release pipelines ids differ, so we'll have to pass the image tag from build pipeline to release one. That is not the problem itself but complicates a bit the solution which is, in fact, to be replaced soon. |
daria-sorokina-da
left a comment
There was a problem hiding this comment.
@daria-sorokina-da made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andreireznikau).
master-prediction-algorithm-build-and-deploy.yml line 37 at r1 (raw file):
Previously, andreireznikau wrote…
Build and release pipelines ids differ, so we'll have to pass the image tag from build pipeline to release one. That is not the problem itself but complicates a bit the solution which is, in fact, to be replaced soon.
Let's have a quick chat about it tomorrow, I'll show you how we solved it in our Gotenberg service
daria-sorokina-da
left a comment
There was a problem hiding this comment.
@daria-sorokina-da resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on andreireznikau).
Enhance deployment pipeline with build context and validation steps
This change is