add stricter arg cleaning rules and add support for -h and -1#11
Open
Bobb-E-Burns wants to merge 6 commits intoAnthonyDiGirolamo:masterfrom
Open
add stricter arg cleaning rules and add support for -h and -1#11Bobb-E-Burns wants to merge 6 commits intoAnthonyDiGirolamo:masterfrom
Bobb-E-Burns wants to merge 6 commits intoAnthonyDiGirolamo:masterfrom
Conversation
added 3 commits
August 27, 2018 19:00
using, i.e ls's `--group-directories-first` would pass on `--rup-directries-first` because the chars `lngo` were stripped from everything before calling `/bin/ls`. I've made it so there is are stricter checks before stripping these chars and now every arg gets passed properly Also goes for checking if recursive ls was enabled, it now also checks for the use of `--recursive` in stead of only `-R`
`file_name` and `extension` would be nil because the line check didn't account for `-h` adding a K after the digits which would cause a TypeError
man ls: ` -1 list one file per line. Avoid '\n' with -q or -b` when `-1` is passed as arg do a simple `puts` to print line for line
Bobb-E-Burns
changed the title
added 3 commits
September 1, 2018 01:00
K,M,G,T,P,E,Z and Y are all the ls SIZE chars
example commands `els -d */` `els -dl */` `ls -1 folder_1 folder2/*` last cmd is similar to calling `ls` with -r or --recursive and performance wise everything seems to be fine but we'll keep actually calling `els` with -r or --recursive disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using, i.e ls's
--group-directories-firstwould pass on--rup-directries-firstbecause the charslngowere stripped from everything before calling/bin/ls.I've made it so there is are stricter checks before stripping these chars and now every arg gets passed properly
Also goes for checking if recursive ls was enabled, it now also checks for the use of
--recursivein stead of only-R