Open
Conversation
…y to be an independent fork), gets rid of all the Objective-C which is producing issues when this is dependended on from an app target wanted to be built as an ARM / Intel fat binary in Xcode 12.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! This PR here for your consideration adds support for AmazonS3RequestManager to build with Swift Package Manager, hopefully without breaking Cocoapods or Carthage builds.
I thought I'd migrate the package to Alamofire 5 also on the same go, but decided this small intermediate of a Alamofire 4.x dependent package would make more sense since a) it's small therefore hopefully easy to review and verify as not breaking other builds and b) turns out I am not comfortable enough with Alamofire's APIs to really know how to do the 4.x -> 5.x translation.