Fix for R6 avatars not being rendered on catalog pages#145
Open
IKedi wants to merge 3 commits into
Open
Conversation
…rame not existing
|
Animations in R6 appear to still be broken on this branch, all other functionality seems to be working. |
Author
Thanks! From what i could tell this addon doesn't use animations from avatar and uses default R15 animations, so i just made a basic conversion to R6, probably not the cleanest implementation. Also R6 swim animation is just run but horizontal, so it looks a bit weird. |
|
I noticed that it also freezes on accessories, so check accessories aswell maybe, as when I have accessories disabled I can move my camera around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix r6 avatars not being rendered on catalog pages due to
acc.bakedCFramenot existing.Tested on a local branch and it renders both R6 and R15 avatars properly, not absolutely sure if everything works as intended.