Add gear charm type and update documentation and CI configuration#3
Merged
Conversation
QiuShui1012
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Create addon by introducing a new “cogwheel” amulet type/item, reorganizing Create integration code into clearer provider/registry units, and refreshing project metadata/docs/CI to support publishing and improved presentation.
Changes:
- Add Cogwheel Amulet item + corresponding amulet type registration, and wire registrations into the addon entrypoint.
- Refactor Create integration pieces: split boiler heater + unpacking integration into dedicated provider classes and remove the old monolithic
CreateIntegration. - Update documentation, mod logo metadata/resources, dependency versions, and CI workflow to support publishing.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/templates/META-INF/neoforge.mods.toml |
Sets logoFile to pack.png for mod UI branding. |
src/main/resources/pack.png |
Adds the logo asset referenced by neoforge.mods.toml. |
src/main/java/dev/anvilcraft/addon/create/util/package-info.java |
Adds non-null-by-default annotations for the util package. |
src/main/java/dev/anvilcraft/addon/create/util/ChargeMovementBehaviour.java |
Removes redundant @NotNull usage and related imports (now relying on package defaults). |
src/main/java/dev/anvilcraft/addon/create/package-info.java |
Adds non-null-by-default annotations for base package. |
src/main/java/dev/anvilcraft/addon/create/mixin/package-info.java |
Adds non-null-by-default annotations for mixin package. |
src/main/java/dev/anvilcraft/addon/create/mixin/MechanicalBearingBlockEntityMixin.java |
Marks shadowed getMovedContraption() as @Nullable to match possible null return. |
src/main/java/dev/anvilcraft/addon/create/integration/CreateIntegration.java |
Removes previous combined integration class (replaced by new providers + entrypoint wiring). |
src/main/java/dev/anvilcraft/addon/create/integration/CreateBoilerHeaterProvider.java |
Introduces a dedicated BoilerHeater provider implementation. |
src/main/java/dev/anvilcraft/addon/create/integration/BatchCrafterUnpackingHandler.java |
Makes the handler also act as a registry provider and simplifies provider registration. |
src/main/java/dev/anvilcraft/addon/create/init/package-info.java |
Adds non-null-by-default annotations for init package. |
src/main/java/dev/anvilcraft/addon/create/init/AdditionItems.java |
Adds COGWHEEL_AMULET item registration (Registrate) and adjusts creative tab defaulting. |
src/main/java/dev/anvilcraft/addon/create/init/AdditionAmuletTypes.java |
Adds the cogwheel amulet type registration and bus registration helper. |
src/main/java/dev/anvilcraft/addon/create/data/package-info.java |
Adds non-null-by-default annotations for data package. |
src/main/java/dev/anvilcraft/addon/create/data/lang/package-info.java |
Adds non-null-by-default annotations for lang data package. |
src/main/java/dev/anvilcraft/addon/create/client/package-info.java |
Adds non-null-by-default annotations for client package. |
src/main/java/dev/anvilcraft/addon/create/client/AnvilCraftCreateAdditionClient.java |
Removes redundant @NotNull annotations from ctor signature. |
src/main/java/dev/anvilcraft/addon/create/AnvilCraftCreateAddition.java |
Wires new providers/registrations (amulet types, boiler heater provider, unpacking provider, amulet registration). |
README.md |
Replaces minimal license note with full Chinese project documentation. |
README.en.md |
Adds English README with full project documentation. |
gradle/libs.versions.toml |
Updates AnvilLib/AnvilCraft versions. |
gradle.properties |
Sets real Modrinth/CurseForge IDs and updates version metadata. |
.github/workflows/ci.yml |
Adds publishing step + properties and env changes for release publishing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Collaborator
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.