fix: resolve snapshot versioning, view replay parity, config bundle hash, and single-address init (#511, #512, #513, #514) - #533
Open
Fatimasanusi wants to merge 1 commit into
Conversation
…e detection in view calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves four technical debt issues (#511, #512, #513, and #514) in
apexchainx_calculatorto improve SLA snapshot schema tracking, calculation view consistency, single-RPC backend bootstrapping, and role initialization documentation.Closes #511
Closes #512
Closes #513
Closes #514
Key Changes
1.
SLAConfigSnapshotVersioning (#511)CONFIG_SNAPSHOT_SCHEMA_VERSION("v1") andCONFIG_SNAPSHOT_SCHEMA_FIELD_COUNT(2) constants inlib.rs.test_config_snapshot_schema_field_count_sentinelinschema_migration_tests.rs.2. Read-Only Duplicate & Replay Policy for
calculate_sla_view(#512)calculate_sla_view(incalculation.rsandlib.rs) to inspect storage history read-only before computing math.Err(SLAError::DuplicateOutageInput)on conflicting duplicate entries and replays the stored result on matching inputs.3.
ConfigBundleHash Bootstrapping (#513)pub config_version_hash: u64toConfigBundlestruct.get_config_bundle()to compute and include the configuration hash.ConfigBundlefrom2to3inapi_stability.rs.4. Single-Address Deployment Documentation & Test Coverage (#514)
admin == operator) ininitialize()doc comments.test_initialize_single_address_merged_rolescovering single-key initialization and subsequent role invocations.Verification Plan
ConfigBundlehash integrity, view replay/duplicate conflict handling, and snapshot versioning.api_stability.rs.