fix(governance): clear a pending operator proposal on renounce_admin - #537
Merged
usmanimamu17-create merged 2 commits intoAug 31, 2026
Conversation
renounce_admin cleared the admin and pending-admin slots but left a pending operator handoff alive, so a stale operator could still call accept_operator and install an operator on an adminless contract. It now clears the pending operator slot (and its expiry timestamp) and emits an op_can event to signal the invalidation, so no pending proposal can complete a role change after renounce. Adds coverage for the clear and for the blocked acceptance path. Closes ApexChainx#470
|
@beulah7717108-eng Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Triggers clippy::len_zero under -D warnings in the Client Checks gate.
usmanimamu17-create
approved these changes
Aug 31, 2026
usmanimamu17-create
left a comment
usmanimamu17-create
left a comment
Contributor
There was a problem hiding this comment.
Looks clean, approved.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renounce_admincleared the admin and pending-admin slots but left a pending operator handoff alive, so a stale candidate could still callaccept_operatorand install an operator on an adminless contract — authority kept flowing after the irreversible renounce.This change makes
renounce_admininvalidate any pending operator proposal: it clears the pending operator slot and its expiry timestamp and emits anop_canevent when one is pending, so no pending proposal can complete a role change after renounce.Changes
governance.rs:renounce_adminnow clearsPENDING_OP_KEY/PENDING_OP_TS_KEYand emitsop_canwhen a proposal was pending.tests.rs: coverage for the cleared pending slot after renounce and for the blocked stale-accept path.Tests
cargo test --libpasses the full suite, including the two new tests that pin the invalidation and the blocked acceptance.Closes #470