fix(governance): set_operator invalidates a pending operator proposal - #538
Merged
usmanimamu17-create merged 2 commits intoAug 31, 2026
Conversation
A direct, admin-only operator assignment left PENDING_OP_KEY intact, so a stale handoff could later complete and silently override the admin's single-step decision. set_operator now clears the pending operator slot and its expiry timestamp and emits an op_can event when one is pending, so the two-step and single-step paths can no longer conflict. Adds coverage for the invalidation and for the blocked stale-accept path. Closes ApexChainx#469
|
@beulah7717108-eng Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Triggers clippy::len_zero under -D warnings in the Client Checks gate.
usmanimamu17-create
approved these changes
Aug 31, 2026
usmanimamu17-create
left a comment
usmanimamu17-create
left a comment
Contributor
There was a problem hiding this comment.
Good fix, let's merge.
usmanimamu17-create
approved these changes
Aug 31, 2026
usmanimamu17-create
left a comment
usmanimamu17-create
left a comment
Contributor
There was a problem hiding this comment.
Nice fix, merging 👍
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_operatorinstalled the operator directly (admin-only) but leftPENDING_OP_KEYintact, so a stale handoff could later complete and silently override the admin's single-step decision — the sequence set_operator(B) then accept_operator(C) would leave C as operator.This change makes a direct assignment invalidate any pending operator proposal: it clears the pending slot and its expiry timestamp and emits an
op_canevent when one is pending, so the two-step and single-step paths can no longer conflict.Changes
governance.rs:set_operatornow clearsPENDING_OP_KEY/PENDING_OP_TS_KEYand emitsop_canwhen a proposal was pending.tests.rs: coverage for the invalidation on direct set and for the blocked stale-accept path.Tests
New tests pins the cleared pending slot, the installed operator, and that the superseded candidate can no longer accept.
Closes #469