refactor: remove orphaned history_snapshot module - #540
Merged
usmanimamu17-create merged 1 commit intoAug 31, 2026
Merged
Conversation
NormalizedSnapshot and normalize_history were documented as the way to summarize history "for dashboard telemetry", but no contract method returned them and the type was not #[contracttype], so it could not cross the contract boundary. The documented dashboard path did not exist and nothing it exposed was actually obtainable on-chain. The dashboard surface is now explicitly get_stats (cumulative aggregate) with get_severity_telemetry (per-severity weekly windows); the module, its lib.rs registration, and its ownership-list entries are removed and the get_stats docs name the supported aggregate so no dashboard path points at an unexposed type. Closes ApexChainx#467
|
@beulah7717108-eng Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
usmanimamu17-create
approved these changes
Aug 31, 2026
usmanimamu17-create
left a comment
usmanimamu17-create
left a comment
Contributor
There was a problem hiding this comment.
Clean refactor, merging.
usmanimamu17-create
approved these changes
Aug 31, 2026
usmanimamu17-create
left a comment
usmanimamu17-create
left a comment
Contributor
There was a problem hiding this comment.
Clean, thanks!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NormalizedSnapshot/normalize_historywere documented as the way to summarize history "for dashboard telemetry", but no contract method returned them and the type was not#[contracttype], so it could not cross the contract boundary. The documented dashboard path did not exist and nothing it exposed was actually obtainable on-chain.The dashboard surface is now explicitly
get_stats(cumulative aggregate) alongsideget_severity_telemetry(per-severity weekly windows), so the dashboard story is one coherent surface.Changes
history_snapshot.rsand itslib.rsmodule registration.docs/MODULE_OWNERSHIP.md: dropped the removed module from the data-layer scope and review tables.lib.rs:get_statsdocs now name it, together withget_severity_telemetry, as the supported dashboard aggregate so no docs present an aggregate the contract cannot return.Tests
The crate compiles and the suite passes after removing the module; no remaining references to
normalize_history/NormalizedSnapshot.Closes #467