feat: canonical decision payloads, settlement self-containment, version-negotiation endpoint, address auth labels - #544
Merged
usmanimamu17-create merged 2 commits intoSep 1, 2026
Conversation
…on-negotiation endpoint, address auth labels - ApexChainx#429: sla_calc and set_int now share the 9-field canonical SLAResult field order with dup_input so a single decoder parses every decision event - ApexChainx#428: set_int carries the full decision (mttr minutes, threshold, rating) so settlement-only consumers reconstruct the SLA decision without a follow-up read - ApexChainx#427: add get_version_negotiation_info exposing protocol_version/min_compatible_protocol/storage/pause/migration state for the multi-contract handshake - ApexChainx#426: get_public_api labels accept_admin/accept_operator as address-scoped ("addr") since they call require_auth and match the pending-slot address, not "none" Closes ApexChainx#429, ApexChainx#428, ApexChainx#427, ApexChainx#426
|
@JamesEjembi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
usmanimamu17-create
approved these changes
Aug 31, 2026
usmanimamu17-create
left a comment
usmanimamu17-create
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
usmanimamu17-create
approved these changes
Aug 31, 2026
usmanimamu17-create
left a comment
usmanimamu17-create
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #429,
Resolves #428,
Resolves #427,
Resolves #426.
#429 — Canonical decision payload across sla_calc / set_int / dup_input
publish_sla_eventandpublish_settlement_intent_eventnow emit the same 9-field canonical tuple(outage_id, status, mttr_minutes, threshold_minutes, amount, payment_type, rating, config_version_hash, recorded_at)already used bydup_input. A single decoder now parses every decision event. Tests assert the shared canonical order and the 9-field decode.#428 — set_int is self-contained for settlement
The settlement-intent event now carries the full decision (rating, mttr minutes, threshold), so settlement-only consumers reconstruct the SLA decision without a follow-up read.
#427 — get_version_negotiation_info
New read-only method exposing
protocol_version,min_compatible_protocol, storage config version, pause and migration state for the multi-contract handshake. Descriptor entry included; get_public_api reports 62 methods (test updated).#426 — accurate address auth labels
get_public_apinow labelsaccept_admin/accept_operatoras"addr"(they callrequire_authfor the contract address), not"none".Verification: cargo check clean (0 warnings); full test suite 599 passed / 0 failed / 5 ignored (includes regression tests for all four issues).