fix(ui, core): improve SSE parser test coverage, fix UI navigation jump/history, and unify error extraction - #465
Open
AbdulSnk wants to merge 2 commits into
Conversation
…mp/history, and unify error extraction
|
@AbdulSnk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
Batch fixes addressing UI navigation UX regressions, missing parser unit tests, and error extraction logic fragmentation across issues #402, #403, #404, and #405.
Key Changes
Test Coverage (#402): Added dedicated unit tests for the session SSE frame parser to cover edge-case framing, payload chunks, and malformed responses.
UX / Table State (#403): Applied { scroll: false } to useOutagesTableState navigation triggers to prevent unexpected viewport page-jumping on filter and pagination updates.
UX / Router Drawer (#404): Refactored the payment drawer state updates from router.replace to router.push (or query state management) so browser back-button interactions naturally close the drawer.
Refactoring & Maintenance (#405): Centralized error extraction logic into a single shared helper, resolving shape drift across outages, SLA, and bulk import services.
Closes: #402
Closes: #403
Closes: #404
Closes: #405