Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/enforce-multiquery-limit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@api-wrappers/igdb-wrapper": patch
---

Reject typed multi-query builders that exceed IGDB's maximum of 10 query blocks per request.
20 changes: 20 additions & 0 deletions src/__tests__/multi-query-limit.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { describe, expect, test } from "bun:test";
import { IGDBValidationError } from "../errors";
import { MultiQueryBuilder } from "../query/MultiQueryBuilder";

describe("MultiQueryBuilder limits", () => {
test("allows at most the 10 queries supported by IGDB", () => {
let builder = new MultiQueryBuilder();

for (let index = 0; index < 10; index++) {
builder = builder.query("games", `query-${index}`, (query) =>
query.limit(1),
);
}

expect(builder.inspect().blocks).toHaveLength(10);
expect(() =>
builder.query("games", "query-10", (query) => query.limit(1)),
).toThrow(IGDBValidationError);
});
});
6 changes: 6 additions & 0 deletions src/query/MultiQueryBuilder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ export class MultiQueryBuilder {
build: QueryFactory<TModel>,
count: boolean,
): MultiQueryBuilder {
if (this.#blocks.length >= 10) {
throw new IGDBValidationError(
"multi-query supports at most 10 queries per IGDB request",
);
}

const normalizedName = name.trim();
if (!normalizedName) {
throw new IGDBValidationError("multi-query name is required");
Expand Down
Loading