Skip to content

fix: guard unsupported endpoint searches - #9

Merged
TDanks2000 merged 7 commits into
mainfrom
agent/guard-unsupported-search
Aug 10, 2026
Merged

fix: guard unsupported endpoint searches#9
TDanks2000 merged 7 commits into
mainfrom
agent/guard-unsupported-search

Conversation

@TDanks2000

Copy link
Copy Markdown
Collaborator

What

  • narrow IGDBSearchableEndpointPath to endpoints actually marked searchable
  • make the high-level IGDBEndpoint.search() helper reject unsupported endpoint paths
  • add regression and type coverage
  • correct the endpoint docs and invalid Companies search example
  • add a patch changeset

Why

IGDB only documents search support for Characters, Collections, Games, Platforms, Themes, plus the dedicated Search endpoint. The wrapper exposed the helper uniformly, so calls such as client.companies.search(...) appeared valid but produced an unsupported IGDB request.

Official reference: https://api-docs.igdb.com/#search

Impact

Unsupported high-level searches now fail early with IGDBValidationError, while supported endpoint searches retain the same API.

Checks

  • regression coverage for supported and unsupported search helpers
  • @ts-expect-error coverage verifies the searchable path type is genuinely narrowed
  • compared branch against main for scope
  • local bun run check was not available in the connector-only environment; CI should be treated as the executable verification

@TDanks2000
TDanks2000 marked this pull request as ready for review August 10, 2026 02:54
@TDanks2000
TDanks2000 merged commit 372e263 into main Aug 10, 2026
1 check passed
@TDanks2000
TDanks2000 deleted the agent/guard-unsupported-search branch August 10, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant