test: add regression tests for CSV query serialization (#28) - #30
Closed
aditya226-sharma wants to merge 1 commit into
Closed
test: add regression tests for CSV query serialization (#28)#30aditya226-sharma wants to merge 1 commit into
aditya226-sharma wants to merge 1 commit into
Conversation
Collaborator
|
Looks good overall, but there’s one issue in the
tmdb.movies.details(550, {
append_to_response: ["credits", "videos", "images"],
})should be: tmdb.movies.details(550, ["credits", "videos", "images"])The current version doesn’t match the method signature and should fail typechecking/runtime. Once that’s fixed and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests for array/comma-separated query option serialization in endpoint methods.
Changes
movies.imageswithinclude_image_language: ["en", "null"]→ serialized asen,nullmovies.detailswithappend_to_response: ["credits", "videos", "images"]→ serialized ascredits,videos,imagestvShows.imageswithinclude_image_language: ["en"]→ serialized asenWhy
Array and comma-separated query options are a common source of serialization bugs. These tests establish regression coverage for the
csv()utility's integration with endpoint methods.Closes #28