Skip to content

⚡ perf: Optimize high concurrency test by wrapping payload in Arc #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panayang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ perf: Optimize high concurrency test by wrapping payload in Arc #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/high_concurrency.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use bincode_next::config;
use bincode_next::decode_async;
use futures_io::AsyncRead;
use std::pin::Pin;
use std::sync::Arc;
use std::task::Context;
use std::task::Poll;
use std::time::Instant;
Expand All @@ -16,7 +17,7 @@ struct BenchPayload {
}

struct PartialReader {
data: Vec<u8>,
data: Arc<Vec<u8>>,
yields: usize,
pos: usize,
}
Expand Down Expand Up @@ -45,7 +46,7 @@ impl AsyncRead for PartialReader {
}

async fn run_worker(
encoded: Vec<u8>
encoded: Arc<Vec<u8>>
) -> core::result::Result<(), bincode_next::error::DecodeError> {
let reader = PartialReader {
data: encoded,
Expand All @@ -63,7 +64,7 @@ async fn test_high_concurrency() {
id: 123456789,
data: "High concurrency testing payload".to_string(),
};
let encoded = bincode_next::encode_to_vec(&payload, config::standard()).unwrap();
let encoded = Arc::new(bincode_next::encode_to_vec(&payload, config::standard()).unwrap());

let total_tasks: usize = 5_000_000;
let batch_size: usize = 50_000;
Expand Down Expand Up @@ -113,7 +114,7 @@ async fn test_high_concurrency_no_batching() {
id: 123456789,
data: "High concurrency testing payload".to_string(),
};
let encoded = bincode_next::encode_to_vec(&payload, config::standard()).unwrap();
let encoded = Arc::new(bincode_next::encode_to_vec(&payload, config::standard()).unwrap());

let concurrency = 5_000_000;
println!(
Expand Down
Loading