Skip to content

Dev - #101

Merged
panayang merged 9 commits into
mainfrom
dev
Jul 6, 2026
Merged

Dev#101
panayang merged 9 commits into
mainfrom
dev

Conversation

@panayang

@panayang panayang commented Jul 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@panayang
panayang requested a review from cn-starlabs July 6, 2026 04:38
Signed-off-by: Xinyu Yang <pana.yang@hotmail.com>
@panayang

panayang commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

I am pretty unsure about the code quality issue as this is acturally done by owen.
Waiting for review.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new module for indefinite summation (anti-difference) and indefinite products, implementing symbolic closed-form rules, numerical evaluation helpers (including an Abel-Plana engine and a series expansion fallback), and AST/DAG integration. The review feedback highlights critical edge cases that need to be addressed: ensuring that closed-form rules for $a^x$ and $x^a$ do not incorrectly simplify expressions like $x^x$ by verifying that the base or exponent is constant with respect to the summation variable, and adding defensive checks to prevent division-by-zero or NaN errors in both symbolic simplification and numerical evaluation when the step size is zero.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/numerical/indefinite_sum.rs Outdated
Comment thread src/numerical/indefinite_sum.rs Outdated
Comment thread src/symbolic/simplify_dag.rs
Comment thread src/symbolic/simplify_dag.rs
Comment thread src/numerical/indefinite_sum.rs
Comment thread src/numerical/indefinite_sum.rs
panayang and others added 5 commits July 6, 2026 12:41
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Xinyu Yang <pana.yang@hotmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Xinyu Yang <pana.yang@hotmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Xinyu Yang <pana.yang@hotmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Xinyu Yang <pana.yang@hotmail.com>
@panayang
panayang merged commit 47759ae into main Jul 6, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants