First screen: pull the SES sentence and the third help answer above the fold - #365
Merged
Conversation
…he fold tests/first-screen.test.mjs shipped with two claims it could not hold. Both were pinned in place instead of at the fold, with the reason written next to each: in DejaVu Sans, the face CI renders, the sentence that says a ParaSign signature is a Simple Electronic Signature ended at y=863 on /parasign and the answer that says the documents sit at Hetzner Nuremberg ended at y=860 on /help. A 390x844 phone is 844 tall. A buyer had to scroll for the two lines those pages exist to put in front of him. Both are gaps, not words, and both are fixed as gaps. On /parasign the mobile media query that already reshapes the hero now also closes the 64px the house .sec-head parks under its rule, to 24px, and the 32px above the buttons, to 24px: the sentence lands at 815. On /help the Q&A block loses 6px of top padding, its heading 6px, each item 8px and each question-to-answer gap 2px: the third answer lands at 822. Not a word of copy moved on either page. The SES sentence is still the one pinned in tests/ui-truthfulness.test.mjs and repeated at about.html:254, and the third answer still names Hetzner Nuremberg, EU law, the GDPR and Resend. The two below: pins are now ordinary fold pins, so every claim in the file holds the same line. `at` carries the position each one was pulled back to and a failure reports the drift against it, which is what the old pin bought and the only part of it worth keeping. Verified with margin-top:400px on .scope-note and on the third .buyer-qa-a: both go red and name the measured y. first-screen, links, seo-contract, ui-truthfulness, site-claims, pricing-fold, pricing-page, frontend-loading-contract, navigation-shell, csp-inline, cache-bust, eslint and static-sanity (11 checks) are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wat er stuk was
tests/first-screen.test.mjs(#364) shipte met twee claims die het niet kon houden. Ze stonden gepind op hun plek in plaats van op de vouw, met de reden ernaast: in DejaVu Sans, het font dat CI rendert, eindigde de zin die zegt dat een ParaSign-handtekening een Simple Electronic Signature is op y=863 op/parasign, en het antwoord dat zegt dat de documenten bij Hetzner Neurenberg staan op y=860 op/help. Een 390x844-telefoon is 844 hoog. Een koper moest scrollen voor precies de twee regels waarvoor die pagina's bestaan.Wat er verandert
Allebei zijn het witruimtes, geen woorden, en allebei worden ze als witruimte gerepareerd.
/parasignSES-zin/helpderde antwoord/parasign: de bestaande@media(max-width:640px)die de hero al herschikt, sluit nu ook de 64px die de huis-.sec-headonder zijn streep parkeert (naar 24px) en de 32px boven de knoppen (naar 24px). Samen 48px. Pagina-lokaal en alleen op telefoonbreedte, net als de rest van dat blok./help: het Q&A-blok verliest 6px bovenpadding, de kop 6px, elk item 8px en elke vraag-naar-antwoord-afstand 2px. Samen 38px.Geen woord copy is verplaatst. De SES-zin is nog steeds die welke
tests/ui-truthfulness.test.mjspint en die letterlijk terugkomt opabout.html:254. Het derde antwoord noemt nog steeds Hetzner Neurenberg, EU-recht, de GDPR en Resend, en de negatieve pins over sleutels zijn ongemoeid.De test
De twee
below:-pins zijn gewone vouwpins geworden, dus elk claim in het bestand houdt nu dezelfde lijn:bottom <= 844. Debelow-tak is weg, met het commentaar over de tijdelijke pin. Wat die pin wel opleverde is bewaard alsat: de positie waarnaar de regel is teruggehaald, die een rode run naast de gemeten waarde noemt.Bewijs
Sabotage met
margin-top:400pxop.scope-noteen op het derde.buyer-qa-a: allebei rood, allebei met de gemeten y in de melding. Zonder sabotage 9/9 groen, gemeten in hetzelfde geforceerde DejaVu Sans dat de suite gebruikt.Groen: first-screen, links, seo-contract, ui-truthfulness, site-claims, pricing-fold, pricing-page, frontend-loading-contract, navigation-shell, csp-inline, cache-bust, eslint, static-sanity (11 checks).
Head-elementen zijn niet aangeraakt: alleen CSS binnen de pagina-lokale
<style>.