The homepage mono kicker leaves the known-defect list - #390
Merged
Conversation
Apolloccrypt
force-pushed
the
fix/known-light-hp-kicker
branch
from
September 3, 2026 02:56
8959c28 to
05818e2
Compare
#389 zette --hp-ink-3 van #66727F naar #5F6B78. Gemeten op deze tak haalt p.hp-kicker op / nu 4.78:1 tegen het tweede papier (#F3F0E8) en 5.12:1 tegen #FAF8F3, allebei boven de 4.5 die AA vraagt. De regel hoort dus niet meer in KNOWN_LIGHT, en die lijst mag alleen korter worden. De vier andere gevallen zijn opnieuw gemeten met een lege lijst en falen alle vier nog: /about a.btn.btn-primary 1:1, /security span.check 1.16:1, /docs code 1.41:1 en 1.48:1, /docs a 1:1 en 1.15:1. Die blijven staan. Bewijs: zonder het geval is theme-contrast groen, 4448 tekstparen over 16 pagina's, 4 van de 4 bekende gevallen nog aanwezig. Zet je --hp-ink-3 in frontend/index.html tijdelijk terug op #66727F, dan valt hij rood met precies dat ene nieuwe geval, / p.hp-kicker 4.31:1.
Apolloccrypt
force-pushed
the
fix/known-light-hp-kicker
branch
from
September 3, 2026 03:33
05818e2 to
6773d2b
Compare
Apolloccrypt
added a commit
that referenced
this pull request
Sep 3, 2026
…e bar is measured on three pages Review of #392 found the hole in the first round. developer.html keeps its own navigation (KEEP_OWN_NAV in frontend/apply-nav.py), is stamped by hand, and carries a hamburger. The round moved Sign in and Help out of the bar below 700px and into a strip under the drawer, and that page never got a strip. So on a 390px screen both links measured 0x0 there, where main still had them in the bar. A page the generator does not own is a page a generated fix does not reach. Three things, because one of them alone would leave the same gap open. The markup. developer.html carries the strip now, like every stamped page. The script. nav.js builds the strip when a page has a menu button and no strip. A page can forget the markup; this cannot forget to build it. That is a floor under the live site, not a substitute for the markup, which is why it comes with the check below rather than instead of it. The check. tests/navigation-shell reads every .html in frontend/, not only the 51 the generator writes, and fails on any page that has id="nav-hamburger" without id="nav-mobile-tail". 52 pages carry the button. Taking the strip back out of developer.html turns it red and names the file. And the measurement moved. The three phone-bar checks ran on the homepage alone, which is exactly why they were green while /developer was broken. They run on /, /pricing and /developer now, each with a fourth check that the strip really holds /auth/login and /help at 44px or more. /developer measures logo x16-95, Create account x181-318, menu x330-374, gaps 86 and 12, all heights 44. 39 checks, all green. Rebased on main with #379, #390 and #391.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
De mono-kicker van de homepage stond als bekend geval in
KNOWN_LIGHTintests/theme-contrast.test.mjs, op 4.31:1 tegen het tweede papier. #389 heeft--hp-ink-3van#66727Fnaar#5F6B78gezet en daarmee haalt hij AA. Deregel is uit de lijst. De lijst wordt korter, nooit langer.
De meting
Gemeten op deze tak,
p.hp-kickerop/, licht, 390 en 1440, na uitgezettetransities:
#FAF8F3#F3F0E8#FAF8F3#FAF8F3#FAF8F3#FAF8F3Tekstkleur overal
rgb(95, 107, 120), 12px. Het slechtste geval is 4.78:1, deregel die eerder 4.31:1 gaf. Identiek op beide breedtes.
Groen zonder het geval
Rood met de sabotage
--hp-ink-3infrontend/index.htmltijdelijk terug op#66727F, daarnateruggedraaid:
Precies dat ene nieuwe geval, en niets anders. De wacht bijt dus nog.
De andere vier gehercontroleerd
De hele lijst is opnieuw gemeten met
KNOWN_LIGHTleeg. Alle vier deovergebleven gevallen falen nog en blijven staan:
/about a.btn.btn-primaryrgb(29, 78, 216)oprgb(29, 78, 216)/security span.checkrgb(178, 255, 63)oprgb(248, 250, 252)/docs codergb(11, 58, 106)oprgb(34, 86, 100)enrgb(134, 61, 34)/docs argb(11, 58, 106)oprgb(11, 58, 106)enrgb(127, 29, 29)Alleen de kicker is dus weg.
Poorten
tests/static-sanity.shPASS (alle 11 blokken),scripts/check-test-declarations.shOK (124 suites),npx eslint@9 .schoon,scripts/check-commit-style.shOK.Herbasseerd op 3cc2df8 (#388, dat 17 frontend-paginaGeen productiecode geraakt, alleen de testlijst en het commentaar erboven.#39;s aanraakt) en daar\nopnieuw gemeten: zelfde uitkomst, alleen de kicker haalt het nu wel.\n\nGeen productiecode geraakt, alleen de testlijst en het commentaar erboven.