Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"@zendeskgarden/react-dropdowns": "^8.75.0",
"@zendeskgarden/react-theming": "^8.75.0",
"analytics": "^0.8.1",
"comuni-province-regioni": "^0.4.3",
"husky": "^7.0.4",
"i18n-iso-countries": "^7.11.0",
"lzutf8": "^0.6.0",
Expand Down
8 changes: 4 additions & 4 deletions src/pages/campaigns/components/campaignForm/FormProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ export interface NewCampaignValues {
targetNotes?: string;
targetSize?: string;
genderRequirements?: {
customerChoice: string;
options: number[];
};
ageRequirements?: {
Expand All @@ -65,6 +64,7 @@ export interface NewCampaignValues {
productType?: string;
notes?: string;
cuf?: { id: string; value: string[] }[];
provinces?: string[];
}

const useGetInitialCufCriteria = ({
Expand Down Expand Up @@ -178,7 +178,6 @@ const FormProvider = ({
productType: dossier?.productType?.id.toString() || "",
notes: dossier?.notes || "",
genderRequirements: {
customerChoice: dossier?.target?.genderQuote || "",
options: dossier?.visibilityCriteria?.gender || [],
},
ageRequirements:
Expand All @@ -187,6 +186,7 @@ const FormProvider = ({
max: r.max,
})) || [],
cuf: initialCufCriteria,
provinces: dossier?.visibilityCriteria?.province || [],
};

const validationSchema = yup.object({
Expand Down Expand Up @@ -242,7 +242,6 @@ const FormProvider = ({
}
),
genderRequirements: yup.object().shape({
customerChoice: yup.string(),
options: yup.array().of(yup.number().oneOf([-1, 0, 1, 2])),
}),
countries: yup.array(),
Expand Down Expand Up @@ -277,6 +276,7 @@ const FormProvider = ({
),
})
),
provinces: yup.array().of(yup.string()),
});
return (
<Formik
Expand Down Expand Up @@ -326,7 +326,6 @@ const FormProvider = ({
? parseInt(values.targetSize)
: undefined,
cap: !!values.targetCap ? parseInt(values.targetCap) : -1, // -1 is passed for no tester cap required
genderQuote: values.genderRequirements?.customerChoice ?? "",
},
browsers: values.browsersList?.map((browser) =>
parseInt(browser, 10)
Expand Down Expand Up @@ -368,6 +367,7 @@ const FormProvider = ({
max: Number(age.max),
}))
: [],
provinces: values.provinces || [],
},
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ const AgeRequirements = () => {
id={field.name}
type="number"
extra={{
min: 14,
max: age.max || undefined,
onBlur: () => form.setFieldTouched(field.name),
}}
Expand All @@ -62,7 +63,7 @@ const AgeRequirements = () => {
id={field.name}
type="number"
extra={{
min: age.min || undefined,
min: age.min || 14,
onBlur: () => form.setFieldTouched(field.name),
}}
value={field.value || ""}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import {
Checkbox,
FormikField,
FormLabel,
TextareaField,
} from "@appquality/appquality-design-system";
import { FieldProps, useFormikContext } from "formik";
import styled from "styled-components";
Expand Down Expand Up @@ -31,7 +30,7 @@ const GenderRequirements = () => {
field,
form,
}: FieldProps<NewCampaignValues["genderRequirements"]>) => {
const value = field.value || { customerChoice: "", options: [] };
const value = field.value || { options: [] as number[] };
return (
<div>
<FormLabel htmlFor={field.name} label={""} />
Expand All @@ -53,12 +52,6 @@ const GenderRequirements = () => {
/>
))}
</CheckboxGrid>
<TextareaField
{...getFieldProps(`${field.name}.customerChoice`)}
label="Customer requirements:"
resize="vertical"
placeholder="Specify any custom gender requirements here"
/>
</div>
);
}}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
import {
ErrorMessage,
FormGroup,
Select,
} from "@appquality/appquality-design-system";
import provinces from "comuni-province-regioni/lib/province";
import { Field as FormikField, FieldProps } from "formik";
import { NewCampaignValues } from "../FormProvider";

const ProvinceSelect = () => {
return (
<FormikField name="provinces">
{({ field, form }: FieldProps<NewCampaignValues["provinces"]>) => {
return (
<FormGroup>
<Select
isMulti
name={field.name}
options={Object.entries(provinces).map(([name, province]) => ({
label: name,
value: province,
}))}
onBlur={field.onBlur}
onChange={(value) => {
form.setFieldValue(
field.name,
value.map((v: SelectOptionType) => v.value),
true
);
}}
label={"Provinces"}
value={field.value?.map((p) => ({ value: p, label: "" })) || []}
/>
<ErrorMessage name={field.name} />
</FormGroup>
);
}}
</FormikField>
);
};

export default ProvinceSelect;
9 changes: 6 additions & 3 deletions src/pages/campaigns/components/campaignForm/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import GenderRequirements from "./fields/GenderRequirements";
import InputField from "./fields/InputField";
import LanguageSelect from "./fields/LanguagesSelect";
import ProductType from "./fields/ProductTypeSelect";
import ProvinceSelect from "./fields/ProvinceSelect";
import CsmSelect from "./fields/roles/CsmSelect";
import PmSelect from "./fields/roles/PMSelect";
import ResearcherSelect from "./fields/roles/ResearcherSelect";
Expand Down Expand Up @@ -274,6 +275,9 @@ const CampaignFormContent = ({ dossier, isEdit, duplicate }: FormProps) => {
</FieldWrapper>
<FieldWrapper>
<CountrySelect />
<div>
<ProvinceSelect />
</div>
<LanguageSelect />
</FieldWrapper>
<FieldWrapper>
Expand All @@ -291,9 +295,6 @@ const CampaignFormContent = ({ dossier, isEdit, duplicate }: FormProps) => {
</div>
</FieldWrapper>
<CufCriteria />
<Title size="s" className="aq-mb-2 aq-pt-4">
Add additional requirements or notes
</Title>
<FieldWrapper>
<div>
<Title size="s" className="aq-mb-2 aq-pt-4">
Expand All @@ -305,6 +306,8 @@ const CampaignFormContent = ({ dossier, isEdit, duplicate }: FormProps) => {
resize="vertical"
placeholder="The target has to..."
/>
</div>
<div style={{ alignSelf: "flex-end", justifySelf: "center" }}>
{dossier && dossier.id && (
<SurveyButton campaign_id={dossier.id.toString()} />
)}
Expand Down
Loading
Loading