Create a login page that redirects to the browser: #1237#1336
Open
Shafaatul-Islam wants to merge 36 commits into
Open
Create a login page that redirects to the browser: #1237#1336Shafaatul-Islam wants to merge 36 commits into
Shafaatul-Islam wants to merge 36 commits into
Conversation
Shafaatul-Islam
changed the title
Shafaatul-Islam
changed the title
LouisPhilippeHeon
requested changes
Feb 27, 2026
Member
LouisPhilippeHeon
left a comment
LouisPhilippeHeon
left a comment
There was a problem hiding this comment.
Comments in bulk:
- Buttons should have icons
- We should add ÉTS's logo on top of the screen (instead of AppETS)
- Login button should be bigger and styled differently
- We should make a gradient for the background color
- The loading indicator should be directly on the login button
https://github.com/ApplETS/Notre-Dame into feature/1237-login-page-that-redirects-to-the-browser
https://github.com/ApplETS/Notre-Dame into feature/1237-login-page-that-redirects-to-the-browser
Contributor
Author
|
LouisPhilippeHeon
requested changes
Apr 12, 2026
…new tests for login_view
https://github.com/ApplETS/Notre-Dame into feature/1237-login-page-that-redirects-to-the-browser
LouisPhilippeHeon
requested changes
Apr 27, 2026
…agement in login_view + use of the exception pattern in login_viewmodel
LouisPhilippeHeon
requested changes
May 4, 2026
|
…ginAccent to spashScreenLogo
|
LouisPhilippeHeon
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1237
📖 Description
Created a new page with a login button and FAQ button. At startup, it will redirect to this new page instead of sending the user to the authentication page.
🧪 How Has This Been Tested?
-Flutter analyze
-All unit tests
-On-device tests
☑️ Checklist before requesting a review
version: Major,version: Minororversion: Patch.🖼️ Screenshots (if useful):