Skip to content

Feature/1383 limit grades widget to single row #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NMoumy merged 7 commits into from
Jun 1, 2026
Merged

Feature/1383 limit grades widget to single row #1384

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5601b2a
init commit
NMoumy Apr 30, 2026
3d171d8
grade in a single row
NMoumy May 5, 2026
2e739f0
[BOT] Applying version.
NMoumy May 5, 2026
226ef2e
Adding a parameter for the direction
NMoumy May 12, 2026
c085bf1
Adding a parameter for the direction
NMoumy May 12, 2026
f503a02
Merge remote-tracking branch 'origin/feature/1383-Limit-grades-widget…
NMoumy May 12, 2026
c5a47e6
Merge branch 'master' into feature/1383-Limit-grades-widget-to-single…
NMoumy May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions lib/ui/dashboard/widgets/grades_card.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,24 +37,25 @@ class GradesCard extends StatelessWidget {

return TitledCard(
title: AppIntl.of(context)!.grades_title,
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
mainAxisSize: MainAxisSize.min,
children: [
if (courses.isEmpty && !loading)
_buildNoGradesContent(context)
else
_buildGradesButton(courses, context, loading: loading),
],
),
child: (courses.isEmpty && !loading)
? _buildNoGradesContent(context)
: _buildGradesButton(courses, context, loading: loading),
);
}

static Widget _buildGradesButton(List<Course> courses, BuildContext context, {bool loading = false}) => Skeletonizer(
static Widget _buildGradesButton(
List<Course> courses,
BuildContext context, {
bool loading = false,
Axis direction = Axis.horizontal,
}) => Skeletonizer(
enabled: loading,
child: Container(
child: SingleChildScrollView(
Copy link
Copy Markdown
Member

@LouisPhilippeHeon LouisPhilippeHeon May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned, we should support vertical layouts so we should add a parameter final Axis direction and replace the row with a flex and do something like direction : this.direction. Same thing for scroll direction

scrollDirection: direction,
padding: const EdgeInsets.fromLTRB(17, 10, 15, 10),
child: Wrap(
child: Flex(
direction: direction,
spacing: 10,
children: courses.map((course) => GradeButton(course, color: context.theme.appColors.backgroundAlt)).toList(),
),
),
Expand Down
Loading