filebeat config is loaded from configMap object#9
Open
epasham wants to merge 8 commits intoApsOps:masterfrom
Open
filebeat config is loaded from configMap object#9epasham wants to merge 8 commits intoApsOps:masterfrom
epasham wants to merge 8 commits intoApsOps:masterfrom
Conversation
ApsOps
requested changes
Oct 17, 2017
| filebeat.prospectors: | ||
| - input_type: log | ||
| paths: | ||
| - "/var/lib/docker/containers/*/*.log" |
Owner
There was a problem hiding this comment.
This needs to be /var/log/containers/*.log to get the metadata from filenames.
| hosts: ${LOGSTASH_HOSTS:?No logstash host configured. Use env var LOGSTASH_HOSTS to set hosts.} | ||
| timeout: 15 | ||
| # Available log levels are: critical, error, warning, info, debug | ||
| logging.level: info |
Owner
There was a problem hiding this comment.
Can you take this config from filebeat.yml in the repo to keep it as default config?
| name: logging-cfg | ||
| items: | ||
| - key: filebeat.yml | ||
| path: filebeat.yml |
Owner
There was a problem hiding this comment.
Probably better to update it in the README?
Author
There was a problem hiding this comment.
kube manifest file and the readme file is updated
Owner
There was a problem hiding this comment.
Do we really need to run this in privileged mode? And this is already in README, so you might as well remove this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filebeat config is loaded from configMap object