[codex] generate sync python platform client - #24
Merged
calvin-archastro merged 2 commits intoJun 12, 2026
Merged
Conversation
|
✅ Clean PR, @calvin-archastro! No blocking findings on
Reply |
calvin-archastro
force-pushed
the
features/calvin-archastro-11-05-2026-messages-sent-notif
branch
3 times, most recently
from
June 12, 2026 17:51
3e70c35 to
18cb817
Compare
calvin-archastro
force-pushed
the
features/calvin-archastro-11-05-2026-messages-sent-notif
branch
from
June 12, 2026 18:35
18cb817 to
f62d0d9
Compare
calvin-archastro
marked this pull request as ready for review
June 12, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates the Python SDK generator for the sync/async client split and Python naming conventions.
PlatformClientis the synchronous REST client backed bySyncHttpClientfrom [codex] add sync Python HTTP client archastro-python#14.AsyncPlatformClientremains the async REST client backed byHttpClient.Async, for exampleAsyncTeamResourceandAsyncV1.TeamResourceandV1.AsyncAuthClientfor async andAuthClientfor sync.PlatformClient, call methods withoutawait, and close each sync client.0.4.0because the generated Python public surface changes.Channel generation remains async-only because Phoenix channel/socket workflows are async.
Diagrams
classDiagram class PlatformClient { V1 v1 AuthClient auth close() with_credentials() } class AsyncPlatformClient { AsyncV1 v1 AsyncAuthClient auth async close() async with_credentials() } class V1 { TeamResource teams } class AsyncV1 { AsyncTeamResource teams } class TeamResource { list() get(team) } class AsyncTeamResource { async list() async get(team) } PlatformClient --> V1 AsyncPlatformClient --> AsyncV1 V1 --> TeamResource AsyncV1 --> AsyncTeamResourceScope
Backend/tooling only: SDK generator and generated Python contract-test templates.
Risk assessment
Medium. This changes generated Python SDK class names and client lifecycle behavior. The change is scoped to Python generation; TypeScript SDK generation and channel runtime behavior are unchanged.
User impact
Generated sync usage:
Generated async usage:
Testing
Passed locally:
npm test -w @archastro/sdk-generator -- --run __tests__/backends/python.test.tsnpm run build -w @archastro/sdk-generatorgit diff --checkFollow-ups and known issues
SyncHttpClientruntime before regenerated Python SDK output is merged.@archastro/sdk-generator@0.4.0before downstream SDK repos update generated Python output to this surface.