fix(sdk-generator): deserialize nullable $ref responses - #85
Merged
Conversation
GET /tasks/{task}/lease is allOf+$ref+nullable. Python/Go/Swift
classified that as an undeserialized shape and aborted generation.
Unwrap outer nullability so the inner model still deserializes,
and accept JSON null at runtime.
Join methods type inline objects as [String: JSONValue]. Contract tests were constructing hoisted LocalToolsItem structs that do not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
GET
/api/v1/tasks/{task}/leaseisallOf: [$ref] + nullable. Python, Go, and Swift sharepythonResponseShape, which treated any non-ref/array/object return as undeserialized and aborted generation. Official Python regen failed on that check.What changed
Unwrap outer
nullable/optionalbefore classifying. Inner$refstill deserializes as a model; JSON null is accepted (Model | None,*Model,Model?). Contract tests acceptNoneor the model.Scope
backend-only (generator). No user-facing product change.
Risk
low. Classifier change is covered by a fixture that is the lease shape.
Testing
npm test --workspace=@archastro/sdk-generator -- __tests__/backends/python.test.ts— 149 passed. Canonical proof:deserializes nullable $ref responses as Model | None.