ci: rebase release version bump PRs - #13
Merged
Merged
Conversation
|
✅ Clean PR, @calvin-archastro! No blocking findings on
Reply |
calvin-archastro
marked this pull request as ready for review
June 11, 2026 21:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The release workflow now merges its automated version-bump pull request with GitHub's rebase merge strategy instead of squash merge.
The release run for
v0.1.1successfully pushed the tag and published to PyPI, but failed after publishing because the repository rejects squash merges. This keeps the release branch and tag behavior unchanged while making the finalmainsync step match the repository's merge settings.Scope
CI-only workflow change. No Python package code, generated SDK code, or publishing configuration changed.
Diagrams
sequenceDiagram participant Maintainer participant ReleaseWorkflow as release workflow participant GitHubCLI as gh cli participant GitHubRepo as GitHub repository participant PublishWorkflow as publish workflow Maintainer->>ReleaseWorkflow: Run release with bump ReleaseWorkflow->>GitHubRepo: Push release branch and version tag ReleaseWorkflow->>PublishWorkflow: Dispatch publish for tag ReleaseWorkflow->>GitHubCLI: Create release PR GitHubCLI->>GitHubRepo: Merge release PR with rebase strategy alt repository allows rebase merge GitHubRepo-->>GitHubCLI: PR merged else repository rejects merge strategy GitHubRepo-->>GitHubCLI: Merge fails endclassDiagram class ReleaseWorkflow { string mergeStrategy createReleasePullRequest() mergeReleasePullRequest() } class RepositoryMergeSettings { bool rebaseMergeAllowed bool squashMergeAllowed bool mergeCommitAllowed } class GitHubCLI { prCreate() prMerge() } ReleaseWorkflow --> GitHubCLI : uses ReleaseWorkflow --> RepositoryMergeSettings : must matchRisk Assessment
Low risk. This changes one GitHub CLI flag in the final release bookkeeping step after tests, branch creation, tag creation, and publish dispatch. The blast radius is limited to future manual
Releaseworkflow runs.User Impact
No direct SDK user impact. Maintainers should see future release runs merge the version bump PR back to
maininstead of failing after a successful publish.Testing
.github/workflows/release.ymlwith Ruby YAML loading.git diff --checkfor the workflow change.gh pr merge --helpsupports--rebaseand--delete-branch.rebaseMergeAllowed: trueandsquashMergeAllowed: false.Follow-Ups And Known Issues
The existing GitHub Actions Node 20 deprecation warning is still present in CI annotations and should be handled separately from this merge-strategy fix.