feat: add repo-validation lint checks and tests (closes #13) - #18
Merged
Conversation
Ports check_plugin_repo.py from archagents with path constants adapted for the archastro-cli layout. All 5 checks are included: 1. Manifest consistency — version/name agreement across the 3 manifests 2. Compat key refs — plugins.<name>.minimumCliVersion references resolve 3. Slash command refs — /<plugin>:<command> references resolve 4. Hardcoded versions — flag literal N.N.N in skill/command prose 5. Version bump on content change — content changes require a manifest version bump so plugin caches refresh 105 unit tests ported from archagents (path fixtures adjusted for archastro layout). Wired into check-plugin-content.yml as two new steps before the existing drift check. fetch-depth: 0 added for the version-bump check. SHA-pinned installer-smoke-test.yml while here. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Ports the 5 repo-validation lint checks and 105 unit tests from archagents, adapted for the archastro-cli layout. Wired into the existing
check-plugin-content.ymlworkflow. Also SHA-pins the installer smoke test workflow.Checks
plugins.<name>.minimumCliVersionreference resolves/<plugin>:<command>reference resolves to a real command fileFiles
scripts/check_plugin_repo.py(612 lines) — all 5 checks + runnerscripts/test_check_plugin_repo.py(1449 lines) — 105 unit tests.github/workflows/check-plugin-content.yml— 3 new steps (tests, checks, fetch-depth: 0).github/workflows/installer-smoke-test.yml— SHA-pinnedactions/checkoutRisk
Low. Adds CI checks that show red on violations. No existing behavior changed. Advisory until branch protection is enabled.
Testing
🤖 Generated with Claude Code