fix(impersonate): restore thin-command / full-skill split - #20
Merged
Conversation
PR #19 copied the archagents impersonate source which had the full body outside the conditional blocks. The command output bloated from 29 to 164 lines. Restructured so {{#SKILL}} wraps the full routing, identity, and session content while {{#CLAUDE_COMMAND}} wraps only the thin CLI passthrough. Command output is now byte-identical to the pre-PR-#19 version (verified against f76db09). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PR #19 copied the archagents impersonate source which had the full body outside the conditional blocks. The command output bloated from 29 to 164 lines — the full routing, identity adoption, and session integration content leaked into what should be a thin CLI passthrough.
Restructured
sources/impersonate.mdso{{#SKILL}}wraps the full content and{{#CLAUDE_COMMAND}}wraps only the thin passthrough. Command output is now byte-identical to the pre-PR-#19 version (verified againstf76db09).Version bumped 0.3.2 → 0.3.3 so the plugin cache refreshes with the corrected command.
Risk
None. The command reverts to Calvin's original thin design. Skill output unchanged.
Testing
python3 scripts/generate-plugin-content.py --check→ 21 files in syncpython3 scripts/check_plugin_repo.py→ all 5 checks pass🤖 Generated with Claude Code