Skip to content

Fix dark mode across Astroshots - #61

Merged
calvin-archastro merged 1 commit into
mainfrom
fix/dark-mode
Aug 13, 2026
Merged

Fix dark mode across Astroshots#61
calvin-archastro merged 1 commit into
mainfrom
fix/dark-mode

Conversation

@calvin-archastro

Copy link
Copy Markdown
Contributor

Summary

  • make the shared Astroshots palette adapt to macOS Aqua and Dark Aqua
  • replace fixed white cards across Settings, stream, detail, friction-log, overlay, and review-sheet surfaces with semantic elevated surfaces
  • explicitly inherit the matching foreground color throughout tray content
  • preserve intentionally black fullscreen review chrome
  • add contrast regression tests for both macOS appearances

Root cause

The app mixed fixed light backgrounds with unstyled SwiftUI text. When macOS switched to dark mode, system text became light while cards remained white, making labels disappear. Backgrounds and foregrounds now switch together through the shared theme.

Verification

  • xcodebuild -project macos/Astroshots.xcodeproj -scheme Astroshots -configuration Debug -derivedDataPath macos/build/DerivedData-dark-mode -skipPackagePluginValidation -only-testing:AstroshotsTests test CODE_SIGNING_ALLOWED=NO — 60 tests passed
  • npm run test:changelog — 2 tests passed
  • git diff --check

@calvin-archastro
calvin-archastro requested a review from a team August 13, 2026 03:36
@calvin-archastro
calvin-archastro merged commit 05aa51e into main Aug 13, 2026
6 checks passed
@calvin-archastro
calvin-archastro deleted the fix/dark-mode branch August 13, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant