Skip to content

feat: badge unseen reviews and keep the tray after full-screen close - #64

Merged
calvin-archastro merged 1 commit into
mainfrom
feat/unseen-review-and-keep-tray
Aug 14, 2026
Merged

feat: badge unseen reviews and keep the tray after full-screen close#64
calvin-archastro merged 1 commit into
mainfrom
feat/unseen-review-and-keep-tray

Conversation

@calvin-archastro

Copy link
Copy Markdown
Contributor

Summary

  • Badge the Shots and Friction Logs tabs with the number of items still to review.
  • Friction logs now follow the same Seen / History path as shots: mark-seen on the row and detail, Unseen vs History filter, persist in each run's review.json. A newer run makes the log unseen again. Hide stays secondary (detail + Settings).
  • Closing the full-screen review viewer restores the menu-bar drawer that opened it (popover or pinned window).

Test plan

  • ReviewWindowControllerTests — close notifies only after the viewer was shown
  • FrictionLogLoaderTests / PreferencesTests — review.json load + unseen/seen counts
  • Rebuild Debug app, open the tray
  • Confirm both tabs show amber unseen badges
  • Mark a friction log Seen → it leaves Unseen, appears in History, badge decrements
  • Open a shot or friction step in the large viewer, close it → tray is still open on the same page
  • Signed AstroshotsReviewUITests (testThumbnailTapOpensReviewTakeover, testClosingReviewRestoresMenuBarPopover) when a matching DEVELOPMENT_TEAM is available

Shots and Friction Logs tabs show how many items still need review.
Friction logs now use the same Unseen/History filter and Seen control
as shots, persisted in each run's review.json. Closing the large
viewer restores the menu-bar drawer that opened it.
@calvin-archastro
calvin-archastro requested a review from a team August 13, 2026 22:40
@calvin-archastro
calvin-archastro merged commit 6aa435c into main Aug 14, 2026
11 checks passed
@calvin-archastro
calvin-archastro deleted the feat/unseen-review-and-keep-tray branch August 14, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant