Skip to content

Configure ArchDev Factory verification - #67

Merged
calvin-archastro merged 1 commit into
mainfrom
fix/archdev-factory-pipeline
Aug 17, 2026
Merged

Configure ArchDev Factory verification#67
calvin-archastro merged 1 commit into
mainfrom
fix/archdev-factory-pipeline

Conversation

@calvin-archastro

@calvin-archastro calvin-archastro commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review on ArchCode

Problem and author intent

archdev init created Astroshots with only app and local project identity. No pipeline_bindings.branch_update was ever configured, so pushes to the private ArchDev remote intentionally created zero daemon jobs. Factory then waited for a result that could never exist, and no Factory branch reached GitHub or became a PR.

This change defines the repository verification pipeline using Astroshots package commands and enables the capture proofs used by CI.

What changed

  • Binds branch_update to a named branch-validation pipeline.
  • Installs dependencies, builds every workspace, and installs Playwright Chromium before tests.
  • Runs typechecks and package-specific tests while excluding only the macOS Screen Recording test that cannot run in a background daemon.
  • Runs review-contract, capture-helper, and changelog tests.
  • Runs skill and package capture proofs with ASTROSHOTS_VERIFY_INTEGRATION=1 and ASTROSHOTS_VERIFY_PACKAGES_CAPTURE=1.
  • Assigns explicit bounded timeouts to every step.

Scope

Repository automation configuration only.

Risk assessment

Medium. This activates verification that was previously disabled, so Factory pushes now execute package installation and the complete daemon-safe test matrix. Every command was exercised locally, including a clean archive with no prebuilt artifacts.

User impact

Factory tasks can now create daemon verification jobs and progress toward GitHub publication. Missing browser binaries and host-only Screen Recording requirements no longer create false failures.

Testing

  • Canonical end-to-end proof: no new test file is added because this PR changes only repository pipeline data. The executable proof is the configured branch-validation sequence itself, validated with the built ArchDev check command.
  • Clean-checkout boundary: git archive HEAD into a temporary directory, then npm ci, npm run build --workspaces --if-present, and node packages/astroshot/bin/astroshot.mjs install-browser all passed without prebuilt dist/ files.
  • All package tests passed: Astroshot CLI 6, movie harness 13 excluding only desktop-macos.test.ts, React 16, TUI unit 14, and TUI E2E 7 with 1 skip.
  • test:review-contract, test:capture-helper, test:changelog, and typecheck passed.
  • ASTROSHOTS_VERIFY_INTEGRATION=1 npm run verify:skills generated and streamed React, Ink, and PTY PNG proofs.
  • ASTROSHOTS_VERIFY_PACKAGES_CAPTURE=1 npm run pack:check installed clean tarball consumers and captured React, Ink, and PTY outputs.
  • git diff --check and ArchDev configuration validation passed.

Follow-ups and known issues

  • The companion Firstlanding PR makes Factory fail fast when this binding is absent, preserves worker work, and fixes production daemon PATH inheritance.
  • npm audit reports one existing high-severity dependency finding; this configuration change does not alter dependencies.

@calvin-archastro
calvin-archastro requested a review from a team August 17, 2026 22:28
@calvin-archastro
calvin-archastro merged commit 4c53f49 into main Aug 17, 2026
6 checks passed
@calvin-archastro
calvin-archastro deleted the fix/archdev-factory-pipeline branch August 17, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant