Configure ArchDev Factory verification - #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
archdev initcreated Astroshots with only app and local project identity. Nopipeline_bindings.branch_updatewas ever configured, so pushes to the private ArchDev remote intentionally created zero daemon jobs. Factory then waited for a result that could never exist, and no Factory branch reached GitHub or became a PR.This change defines the repository verification pipeline using Astroshots package commands and enables the capture proofs used by CI.
What changed
branch_updateto a namedbranch-validationpipeline.ASTROSHOTS_VERIFY_INTEGRATION=1andASTROSHOTS_VERIFY_PACKAGES_CAPTURE=1.Scope
Repository automation configuration only.
Risk assessment
Medium. This activates verification that was previously disabled, so Factory pushes now execute package installation and the complete daemon-safe test matrix. Every command was exercised locally, including a clean archive with no prebuilt artifacts.
User impact
Factory tasks can now create daemon verification jobs and progress toward GitHub publication. Missing browser binaries and host-only Screen Recording requirements no longer create false failures.
Testing
branch-validationsequence itself, validated with the built ArchDevcheckcommand.git archive HEADinto a temporary directory, thennpm ci,npm run build --workspaces --if-present, andnode packages/astroshot/bin/astroshot.mjs install-browserall passed without prebuiltdist/files.desktop-macos.test.ts, React 16, TUI unit 14, and TUI E2E 7 with 1 skip.test:review-contract,test:capture-helper,test:changelog, andtypecheckpassed.ASTROSHOTS_VERIFY_INTEGRATION=1 npm run verify:skillsgenerated and streamed React, Ink, and PTY PNG proofs.ASTROSHOTS_VERIFY_PACKAGES_CAPTURE=1 npm run pack:checkinstalled clean tarball consumers and captured React, Ink, and PTY outputs.git diff --checkand ArchDev configuration validation passed.Follow-ups and known issues
npm auditreports one existing high-severity dependency finding; this configuration change does not alter dependencies.