Core: Fix loading of worlds installed in launcher - #6319
Open
duckboycool wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
affects: core
duckboycool
added
the
is: bug/fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Until 0.6.7, the installing a world in the launcher attempted to load it, meaning it could actually be used without launcher restart so long as it wasn't replacing an already loaded world. However, this has now broken (example: https://discord.com/channels/731205301247803413/1520174054278172844) due to the changes in loading from #5734, which the install component wasn't adapted for. (This also didn't really alert the user about a failed load, see #6292.)
This makes it so the worlds this way also get added to
apworld_module_specsbefore loading. This seems to work fine, although I'm not positive if this is the preferred way of doing this.How was this tested?
Loading worlds normally, including with APQuest as an
.apworldrather than folder. Testing that generating templates after installing a world actually works now. I also made a frozen build and checked that things were working there as well.If this makes graphical changes, please attach screenshots.
🚀🚫💥