Skip to content

The Messenger: Fix transition plando for one way transitions - #6327

Open
Jouramie wants to merge 7 commits into
ArchipelagoMW:mainfrom
Jouramie:messenger/fix-artificer-plando
Open

The Messenger: Fix transition plando for one way transitions#6327
Jouramie wants to merge 7 commits into
ArchipelagoMW:mainfrom
Jouramie:messenger/fix-artificer-plando

Conversation

@Jouramie

@Jouramie Jouramie commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

What is this fixing or adding?

I realized while working on deferred entrances for UT that I needed so much code to try to handle Artificer's Challenge and Portal, and it was not even working correctly, because the plando was broken.

This fixes the transition plando for one way entrances/exits by giving clear names to the level exists. Then, it clarifies that the entrance in plando should be the name of the level exit, and exit is the destination. This also removes all the special semi-working edge cases to handle one way entrances, and instead declare them as part of a one way entrances/exits lists.

Currently on main, a yaml like this fails.

  plando_connections:
    - entrance: "Elemental Skylands - Right"
      exit: "Glacial Peak - Left"

It says

ValueError: Connection between 'Elemental Skylands - Right' and 'Glacial Peak - Left' is invalid.

It also fails if you try to plando anything for Artificer or Tower HQ. It was not very clear anyway which one was supposed to be what exit.

Note that there still is this bug that prevent plandoed transitions from being in slot data. But with both PR the option is now fully functionnal.

This also fix a logic bug with the rule of Glacial Peak top not being applied to the correct transition.

How was this tested?

Add some tests to make sure they can now roll.

Also generated a game on main and on my branch with the same seed and validated that the slot data contains the same placements. No change required on the mod side because the slot that is built with the destination replacements, not the exits.

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions Bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jul 12, 2026
@Jouramie Jouramie changed the title The Messenger: Fix transition plando for The Messenger: Fix transition plando for one way transitions Jul 12, 2026
@Jouramie Jouramie added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jul 13, 2026
@Jouramie

Copy link
Copy Markdown
Collaborator Author

All the tests of the web stacker appear to fail because ValueError: The name 'api' is already registered for this blueprint. Use 'name=' to provide a unique name.. Idk what that is and I'm very confused because I have not touched that... 🤔

@Jouramie
Jouramie requested a review from alwaysintreble July 13, 2026 11:06
Jouramie added a commit to Jouramie/Archipelago that referenced this pull request Jul 18, 2026
Jouramie added a commit to Jouramie/Archipelago that referenced this pull request Jul 19, 2026
Jouramie added a commit to Jouramie/Archipelago that referenced this pull request Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant