The Messenger: Fix transition plando for one way transitions - #6327
Open
Jouramie wants to merge 7 commits into
Open
The Messenger: Fix transition plando for one way transitions#6327Jouramie wants to merge 7 commits into
Jouramie wants to merge 7 commits into
Conversation
Collaborator
Author
|
All the tests of the web stacker appear to fail because |
Jouramie
added a commit
to Jouramie/Archipelago
that referenced
this pull request
Jul 18, 2026
Jouramie
added a commit
to Jouramie/Archipelago
that referenced
this pull request
Jul 19, 2026
Jouramie
added a commit
to Jouramie/Archipelago
that referenced
this pull request
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
I realized while working on deferred entrances for UT that I needed so much code to try to handle Artificer's Challenge and Portal, and it was not even working correctly, because the plando was broken.
This fixes the transition plando for one way entrances/exits by giving clear names to the level exists. Then, it clarifies that the
entrancein plando should be the name of the level exit, andexitis the destination. This also removes all the special semi-working edge cases to handle one way entrances, and instead declare them as part of a one way entrances/exits lists.Currently on main, a yaml like this fails.
It says
It also fails if you try to plando anything for
ArtificerorTower HQ. It was not very clear anyway which one was supposed to be what exit.Note that there still is this bug that prevent plandoed transitions from being in slot data. But with both PR the option is now fully functionnal.
This also fix a logic bug with the rule of Glacial Peak top not being applied to the correct transition.
How was this tested?
Add some tests to make sure they can now roll.
Also generated a game on main and on my branch with the same seed and validated that the slot data contains the same placements. No change required on the mod side because the slot that is built with the destination replacements, not the exits.
If this makes graphical changes, please attach screenshots.
N/A