kvui: fix ZeroDivisionError on windows after monitor reset by setting fixed DPI - #6341
Open
Berserker66 wants to merge 2 commits into
Open
kvui: fix ZeroDivisionError on windows after monitor reset by setting fixed DPI#6341Berserker66 wants to merge 2 commits into
Berserker66 wants to merge 2 commits into
Conversation
github-actions
Bot
added
affects: core
Collaborator
|
Is this something that should be removed once kivy does a new release, or would it make sense to keep this even after it's dealt with upstream? If it's the former, it'd probably be worth having a comment saying that. |
Member
Author
|
We have kivy's DPI scaling disabled anyway, so it would be safe to keep around, all it should do is skip some calculations that we don't need anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
On Windows after a monitor is "lost", such as by the system going to sleep, if any kivy clients were on that monitor then the clients would spam a ZeroDivisionError on any mouse move event going through them. We already have disabled DPI aware scaling, so we can just kill off even more of that system and "fix" the exception spam.
How was this tested?
On my 3-monitor windows 11 system.
If this makes graphical changes, please attach screenshots.